win/clang: Suppress -Winline-new-delete and -Wimplicit-exception-spec-mismatch

win/clang: Suppress -Winline-new-delete and -Wimplicit-exception-spec-mismatch
while building icu.

The warning isn't very serious, and these functions are supposed to trap. Since
ICU's operator new/delete overrides are technically invalid, I filed
http://bugs.icu-project.org/trac/ticket/11122 with ICU for this.

BUG=82385
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291699

[Nico, 2014-08-27 22:28:00]

thakis@chromium.org changed reviewers:
+ hans@chromium.org

[Nico, 2014-08-27 22:28:00]

:-/

[Nico, 2014-08-27 22:36:11]

Please pretend that patch set 1 never existed and click through for patch
set 2 9_9


On Wed, Aug 27, 2014 at 3:28 PM, <thakis@chromium.org> wrote:

> Reviewers: hans,
>
> Message:
> :-/
>
> Description:
> win/clang: Suppress -Winline-new-delete and -Wimplicit-exception-spec-
> mismatch
> while building icu.
>
> The warning isn't very serious, and these functions are supposed to trap.
> Since
> ICU's operator new/delete overrides are technically invalid, I filed
> http://bugs.icu-project.org/trac/ticket/11122 with ICU for this.
>
> BUG=82385
>
> Please review this at https://codereview.chromium.org/508343002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/
>
> Affected files (+13, -0 lines):
>   M     icu.gyp
>
>
> Index: icu.gyp
> ===================================================================
> --- icu.gyp     (revision 291697)
> +++ icu.gyp     (working copy)
> @@ -331,6 +331,19 @@
>                  'source/stubdata/stubdata.c',
>                ],
>              }],
> +            [ 'OS == "win" and clang==1', {
> +              # Note: General clang warnings should go in the
> +              # clang_warning_flags block above.
> +              'msvs_settings': {
> +                'VCCLCompilerTool': {
> +                  'AdditionalOptions': [
> +                    # See http://bugs.icu-project.org/trac/ticket/11122
> +                    '-Wno-inline-new-delete',
> +                    '-no-Wimplicit-exception-spec-mismatch',
> +                  ],
> +                },
> +              },
> +            }],
>              ['OS == "android" and use_system_stlport == 1', {
>                'target_conditions': [
>                  ['_toolset == "target"', {
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Reid Kleckner, 2014-08-27 23:59:25]

The CQ bit was checked by rnk@chromium.org

[Reid Kleckner, 2014-08-27 23:59:26]

rnk@chromium.org changed reviewers:
+ rnk@chromium.org

[Reid Kleckner, 2014-08-27 23:59:26]

lgtm

[commit-bot: I haz the power, 2014-08-28 00:00:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/508343002/20001

[commit-bot: I haz the power, 2014-08-28 00:00:25]

Committed patchset #2 (id:20001) as 291699