mac: Add traffic lights to fullscreen mode in Yosemite.

mac: Add traffic lights to fullscreen mode in Yosemite.

No fancy animations, this just adds basic functionality. In fullscreen mode,
the tabs are shifted over, and traffic light buttons are manually added in.

BUG=405564
Committed: https://crrev.com/a9900086b8a10de59965e9ab76b58fdb9e4300c1
Cr-Commit-Position: refs/heads/master@{#293357}

[erikchen, 2014-08-27 23:21:51]

Patchset #1 (id:1) has been deleted

[erikchen, 2014-08-27 23:21:55]

Patchset #1 (id:20001) has been deleted

[erikchen, 2014-08-27 23:22:35]

erikchen@chromium.org changed reviewers:
+ rsesek@chromium.org

[erikchen, 2014-08-27 23:22:35]

rsesek: Please review.

Note that this CL depends on https://codereview.chromium.org/493143004/.

[Robert Sesek, 2014-09-02 19:01:05]

https://codereview.chromium.org/508313002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

https://codereview.chromium.org/508313002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:2179: NSRect frame =
NSMakeRect(0, 0, self.leftIndentForControls, height);
This file has an overwhelming preference against dot-notation, so I'd avoid it
here.

https://codereview.chromium.org/508313002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:2192: [closeButton
setFrameOrigin:NSMakePoint(11, buttonY)];
Pull these magic numbers into method-local magic numbers, at least.

[erikchen, 2014-09-03 00:31:44]

rsesek: PTAL

Diff patch set 3 against patch set 2.

https://codereview.chromium.org/508313002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

https://codereview.chromium.org/508313002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:2179: NSRect frame =
NSMakeRect(0, 0, self.leftIndentForControls, height);
On 2014/09/02 19:01:05, rsesek wrote:
> This file has an overwhelming preference against dot-notation, so I'd avoid it
> here.

I removed all instances of dot notation from this method.

https://codereview.chromium.org/508313002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:2192: [closeButton
setFrameOrigin:NSMakePoint(11, buttonY)];
On 2014/09/02 19:01:05, rsesek wrote:
> Pull these magic numbers into method-local magic numbers, at least.

Done.

[Robert Sesek, 2014-09-03 17:52:25]

LGTM

[erikchen, 2014-09-04 17:15:01]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-09-04 17:16:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/508313002/100001

[commit-bot: I haz the power, 2014-09-04 19:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 19:15:19]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/51650)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2014-09-04 19:24:38]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-09-04 19:25:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/508313002/120001

[commit-bot: I haz the power, 2014-09-04 22:21:00]

Committed patchset #5 (id:120001) as 155a6795767438710ef2aa2c1ab84006751b25e5

[commit-bot: I haz the power, 2014-09-10 03:33:18]

Patchset 5 (id:??) landed as
https://crrev.com/a9900086b8a10de59965e9ab76b58fdb9e4300c1
Cr-Commit-Position: refs/heads/master@{#293357}