Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 508293003: Change media MessageLoopProxy usage to SingleThreadTaskRunners. (Closed)

Created:
6 years, 3 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change media MessageLoopProxy usage to SingleThreadTaskRunners. Changing WebMediaPlayerImpl and related media code to use task runners instead of MessageLoopProxy to avoid presubmit errors when moving this code to media/blink. There is no functional change here. Just making the tools happy. :) BUG=408338 Committed: https://crrev.com/b403494cafdf7f9222fc6e4df0d254691d4f186a Cr-Commit-Position: refs/heads/master@{#292389}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment #

Patch Set 3 : Fix Android Build errors. #

Patch Set 4 : More Android fixes #

Patch Set 5 : Rebase #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -208 lines) Patch
M content/renderer/media/android/media_source_delegate.h View 1 2 3 4 chunks +12 lines, -8 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 2 3 4 5 29 chunks +42 lines, -42 lines 0 comments Download
M content/renderer/media/android/renderer_demuxer_android.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/renderer_demuxer_android.cc View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 3 4 5 4 chunks +12 lines, -10 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/buffered_data_source.h View 3 chunks +11 lines, -10 lines 0 comments Download
M content/renderer/media/buffered_data_source.cc View 19 chunks +23 lines, -23 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/texttrack_impl.h View 4 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/media/texttrack_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 2 3 4 38 chunks +66 lines, -64 lines 0 comments Download
M content/renderer/pepper/video_decoder_shim.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/pepper/video_decoder_shim.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
acolwell GONE FROM CHROMIUM
acolwell@chromium.org changed reviewers: + jamesr@chromium.org, scherkus@chromium.org
6 years, 3 months ago (2014-08-28 00:43:53 UTC) #1
acolwell GONE FROM CHROMIUM
6 years, 3 months ago (2014-08-28 00:44:49 UTC) #2
scherkus (not reviewing)
lgtm w/ nit https://codereview.chromium.org/508293003/diff/1/content/renderer/media/renderer_gpu_video_accelerator_factories.h File content/renderer/media/renderer_gpu_video_accelerator_factories.h (right): https://codereview.chromium.org/508293003/diff/1/content/renderer/media/renderer_gpu_video_accelerator_factories.h#newcode35 content/renderer/media/renderer_gpu_video_accelerator_factories.h:35: // the |message_loop_proxy_|, as provided during ...
6 years, 3 months ago (2014-08-28 00:48:43 UTC) #3
jamesr
lgtm
6 years, 3 months ago (2014-08-28 00:49:26 UTC) #4
acolwell GONE FROM CHROMIUM
Thanks for the quick review guys. :) https://codereview.chromium.org/508293003/diff/1/content/renderer/media/renderer_gpu_video_accelerator_factories.h File content/renderer/media/renderer_gpu_video_accelerator_factories.h (right): https://codereview.chromium.org/508293003/diff/1/content/renderer/media/renderer_gpu_video_accelerator_factories.h#newcode35 content/renderer/media/renderer_gpu_video_accelerator_factories.h:35: // the ...
6 years, 3 months ago (2014-08-28 00:52:48 UTC) #5
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 3 months ago (2014-08-28 00:52:58 UTC) #6
acolwell GONE FROM CHROMIUM
The CQ bit was unchecked by acolwell@chromium.org
6 years, 3 months ago (2014-08-28 00:53:08 UTC) #7
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 3 months ago (2014-08-28 00:56:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/508293003/40001
6 years, 3 months ago (2014-08-28 01:00:22 UTC) #9
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 3 months ago (2014-08-28 04:31:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/508293003/100001
6 years, 3 months ago (2014-08-28 04:32:19 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 05:24:38 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 06:25:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/10866)
6 years, 3 months ago (2014-08-28 06:25:15 UTC) #14
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 3 months ago (2014-08-28 15:02:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/508293003/100001
6 years, 3 months ago (2014-08-28 15:03:48 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 1c54312277f638b9c09bbd29873ba89dd72de64f
6 years, 3 months ago (2014-08-28 15:42:53 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:49 UTC) #18
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/b403494cafdf7f9222fc6e4df0d254691d4f186a
Cr-Commit-Position: refs/heads/master@{#292389}

Powered by Google App Engine
This is Rietveld 408576698