Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 508283003: Fix resources grit paths. (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/5b8e82f589213a4137bd2307aeabfa27038a3de7 Cr-Commit-Position: refs/heads/master@{#292409}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M athena/main/DEPS View 1 2 chunks +1 line, -1 line 0 comments Download
M athena/main/placeholder.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/resources/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/resources/athena_resources.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 3 months ago (2014-08-28 00:21:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/508283003/1
6 years, 3 months ago (2014-08-28 00:27:49 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 01:24:13 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:28:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/58458)
6 years, 3 months ago (2014-08-28 01:28:20 UTC) #5
oshima
lgtm thanks!
6 years, 3 months ago (2014-08-28 01:36:11 UTC) #6
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 3 months ago (2014-08-28 16:48:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/508283003/1
6 years, 3 months ago (2014-08-28 16:49:26 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 16:54:01 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 16:58:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/58771)
6 years, 3 months ago (2014-08-28 16:58:13 UTC) #11
Jun Mukai
Committed patchset #2 (id:20001) to pending queue manually as 9f63356 (presubmit successful).
6 years, 3 months ago (2014-08-28 17:11:54 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:25 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5b8e82f589213a4137bd2307aeabfa27038a3de7
Cr-Commit-Position: refs/heads/master@{#292409}

Powered by Google App Engine
This is Rietveld 408576698