Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 508263003: Add getSelf method to management API to use without the "management" permission. (Closed)

Created:
6 years, 3 months ago by Daniel Nishi
Modified:
6 years, 3 months ago
Reviewers:
scheib, Ilya Sherman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add getSelf method to management API to use without the "management" permission. BUG=392215 Committed: https://crrev.com/5780ffac611477a24274a7cdeb16bfde4b672640 Cr-Commit-Position: refs/heads/master@{#292660}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Document the non-required permission elsewhere. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -4 lines) Patch
M chrome/browser/extensions/api/management/management_api.h View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/management.json View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/management.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/management/get_self/background.js View 1 chunk +11 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/management/get_self/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Daniel Nishi
dhnishi@chromium.org changed reviewers: + isherman@chromium.org, scheib@chromium.org
6 years, 3 months ago (2014-08-28 20:55:41 UTC) #1
Daniel Nishi
isherman@chromium.org: Please review histogram changes. scheib@chromium.org: Please review changes in chrome/browser/extensions/*, chrome/common/extensions/*, and chrome/test/*. https://codereview.chromium.org/508263003/diff/1/chrome/common/extensions/api/_api_features.json ...
6 years, 3 months ago (2014-08-28 20:55:41 UTC) #2
Daniel Nishi
scheib@chromium.org: Please review changes in chrome/browser/extensions/*, chrome/common/extensions/*, and chrome/test/*. isherman@chromium.org: Please review changes in histograms.
6 years, 3 months ago (2014-08-28 20:56:32 UTC) #3
scheib
lgtm with additional doc request. https://codereview.chromium.org/508263003/diff/1/chrome/common/extensions/api/_api_features.json File chrome/common/extensions/api/_api_features.json (right): https://codereview.chromium.org/508263003/diff/1/chrome/common/extensions/api/_api_features.json#newcode549 chrome/common/extensions/api/_api_features.json:549: "channel": "stable", On 2014/08/28 ...
6 years, 3 months ago (2014-08-28 21:32:35 UTC) #4
Daniel Nishi
https://codereview.chromium.org/508263003/diff/1/chrome/common/extensions/api/_api_features.json File chrome/common/extensions/api/_api_features.json (right): https://codereview.chromium.org/508263003/diff/1/chrome/common/extensions/api/_api_features.json#newcode549 chrome/common/extensions/api/_api_features.json:549: "channel": "stable", On 2014/08/28 21:32:35, scheib wrote: > On ...
6 years, 3 months ago (2014-08-28 22:04:17 UTC) #5
Ilya Sherman
histograms lgtm
6 years, 3 months ago (2014-08-28 22:40:23 UTC) #6
Daniel Nishi
The CQ bit was checked by dhnishi@chromium.org
6 years, 3 months ago (2014-08-28 22:56:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/508263003/20001
6 years, 3 months ago (2014-08-28 22:57:05 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 23:58:51 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 01:32:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/4275)
6 years, 3 months ago (2014-08-29 01:32:16 UTC) #11
Daniel Nishi
The CQ bit was checked by dhnishi@chromium.org
6 years, 3 months ago (2014-08-29 16:20:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/508263003/40001
6 years, 3 months ago (2014-08-29 16:21:10 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a77f7ccf01dee0ace8aef2dbfd596f0b5383ea7f
6 years, 3 months ago (2014-08-29 17:14:43 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:09:44 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5780ffac611477a24274a7cdeb16bfde4b672640
Cr-Commit-Position: refs/heads/master@{#292660}

Powered by Google App Engine
This is Rietveld 408576698