Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6324)

Unified Diff: chrome/browser/ui/zoom/zoom_controller_unittest.cc

Issue 508263002: Simplify ZoomController by removing DefaultZoomLevel prefs machinery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/zoom/zoom_controller_unittest.cc
diff --git a/chrome/browser/ui/zoom/zoom_controller_unittest.cc b/chrome/browser/ui/zoom/zoom_controller_unittest.cc
index 5b7c6186cb19359a0715b00e6b5140fb2098dc3b..53559e7cd87335479dadcdf4c8add4be8b986656 100644
--- a/chrome/browser/ui/zoom/zoom_controller_unittest.cc
+++ b/chrome/browser/ui/zoom/zoom_controller_unittest.cc
@@ -65,23 +65,6 @@ TEST_F(ZoomControllerTest, DidNavigateMainFrame) {
content::FrameNavigateParams());
}
-TEST_F(ZoomControllerTest, OnPreferenceChanged) {
- double zoom_level = zoom_controller_->GetZoomLevel();
- // Note that while the change in the default zoom level triggers an event,
- // the current zoom level for this web contents does not change since the
- // default zoom level in HostZoomMap is not updated.
- // TODO(wjmaclean) Make sure changes to the default zoom level in preferences
- // propagate to HostZoomMap. http://crbug.com/391484
- ZoomController::ZoomChangedEventData zoom_change_data(
- web_contents(),
- zoom_level,
- zoom_level,
- ZoomController::ZOOM_MODE_DEFAULT,
- false);
- EXPECT_CALL(zoom_observer_, OnZoomChanged(zoom_change_data)).Times(1);
- profile()->GetPrefs()->SetDouble(prefs::kDefaultZoomLevel, 110.0);
-}
-
TEST_F(ZoomControllerTest, Observe) {
double new_zoom_level = 110.0;
// When the event is initiated from HostZoomMap, the old zoom level is not
« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698