Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3414)

Unified Diff: chrome/browser/ui/zoom/zoom_controller.cc

Issue 508263002: Simplify ZoomController by removing DefaultZoomLevel prefs machinery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller.h ('k') | chrome/browser/ui/zoom/zoom_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/zoom/zoom_controller.cc
diff --git a/chrome/browser/ui/zoom/zoom_controller.cc b/chrome/browser/ui/zoom/zoom_controller.cc
index aff4a84a98bae5800e4813b32294713503723758..fd9a3dc1d679adad6412a23ae3f2fc231a9b2b67 100644
--- a/chrome/browser/ui/zoom/zoom_controller.cc
+++ b/chrome/browser/ui/zoom/zoom_controller.cc
@@ -4,17 +4,10 @@
#include "chrome/browser/ui/zoom/zoom_controller.h"
-#include "base/prefs/pref_service.h"
-#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/zoom/zoom_event_manager.h"
#include "chrome/browser/ui/zoom/zoom_observer.h"
-#include "chrome/common/pref_names.h"
#include "content/public/browser/host_zoom_map.h"
#include "content/public/browser/navigation_entry.h"
-#include "content/public/browser/notification_details.h"
-#include "content/public/browser/notification_service.h"
-#include "content/public/browser/notification_types.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
@@ -31,19 +24,14 @@ ZoomController::ZoomController(content::WebContents* web_contents)
zoom_mode_(ZOOM_MODE_DEFAULT),
zoom_level_(1.0),
browser_context_(web_contents->GetBrowserContext()) {
- Profile* profile =
- Profile::FromBrowserContext(web_contents->GetBrowserContext());
- default_zoom_level_.Init(
- prefs::kDefaultZoomLevel,
- profile->GetPrefs(),
- base::Bind(
- &ZoomController::UpdateState, base::Unretained(this), std::string()));
- zoom_level_ = default_zoom_level_.GetValue();
-
- zoom_subscription_ = content::HostZoomMap::GetDefaultForBrowserContext(
- browser_context_)->AddZoomLevelChangedCallback(
- base::Bind(&ZoomController::OnZoomLevelChanged,
- base::Unretained(this)));
+ // TODO(wjmaclean) Make calls to HostZoomMap::GetDefaultForBrowserContext()
+ // refer to the webcontents-specific HostZoomMap when that becomes available.
+ content::HostZoomMap* host_zoom_map =
+ content::HostZoomMap::GetDefaultForBrowserContext(browser_context_);
+ zoom_level_ = host_zoom_map->GetDefaultZoomLevel();
+
+ zoom_subscription_ = host_zoom_map->AddZoomLevelChangedCallback(
+ base::Bind(&ZoomController::OnZoomLevelChanged, base::Unretained(this)));
UpdateState(std::string());
}
@@ -51,15 +39,14 @@ ZoomController::ZoomController(content::WebContents* web_contents)
ZoomController::~ZoomController() {}
bool ZoomController::IsAtDefaultZoom() const {
- return content::ZoomValuesEqual(GetZoomLevel(),
- default_zoom_level_.GetValue());
+ return content::ZoomValuesEqual(GetZoomLevel(), GetDefaultZoomLevel());
}
int ZoomController::GetResourceForZoomLevel() const {
if (IsAtDefaultZoom())
return IDR_ZOOM_NORMAL;
- return GetZoomLevel() > default_zoom_level_.GetValue() ? IDR_ZOOM_PLUS
- : IDR_ZOOM_MINUS;
+ return GetZoomLevel() > GetDefaultZoomLevel() ? IDR_ZOOM_PLUS
+ : IDR_ZOOM_MINUS;
}
void ZoomController::AddObserver(ZoomObserver* observer) {
@@ -227,7 +214,7 @@ void ZoomController::SetZoomMode(ZoomMode new_mode) {
// the zoom level is handled independently.
if (zoom_mode_ != ZOOM_MODE_DISABLED) {
zoom_map->SetTemporaryZoomLevel(
- render_process_id, render_view_id, default_zoom_level_.GetValue());
+ render_process_id, render_view_id, GetDefaultZoomLevel());
zoom_level_ = original_zoom_level;
} else {
// When we don't call any HostZoomMap set functions, we send the event
@@ -241,7 +228,7 @@ void ZoomController::SetZoomMode(ZoomMode new_mode) {
case ZOOM_MODE_DISABLED: {
// The page needs to be zoomed back to default before disabling the zoom
zoom_map->SetTemporaryZoomLevel(
- render_process_id, render_view_id, default_zoom_level_.GetValue());
+ render_process_id, render_view_id, GetDefaultZoomLevel());
break;
}
}
« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller.h ('k') | chrome/browser/ui/zoom/zoom_controller_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698