Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 508253003: Use valid bpc value in LoadPalette() and ContinueToLoadMask() (Closed)

Created:
6 years, 3 months ago by Bo Xu
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, jun_fang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Use valid bpc value in LoadPalette() and ContinueToLoadMask() BUG=408141, 408147 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/405478d

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 4 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bo Xu
bo_xu@foxitsoftware.com changed reviewers: + jun_fang@foxitsoftware.com, tsepez@chromium.org
6 years, 3 months ago (2014-08-27 20:11:32 UTC) #1
Bo Xu
I changed the GetValidBpc() as well, get rid of the bpc==12. 12 is not a ...
6 years, 3 months ago (2014-08-27 20:11:32 UTC) #2
Tom Sepez
https://codereview.chromium.org/508253003/diff/1/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right): https://codereview.chromium.org/508253003/diff/1/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp#newcode858 core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:858: FX_DWORD bpc = GetValidBpc(); Do we want to return ...
6 years, 3 months ago (2014-08-27 20:26:49 UTC) #3
Bo Xu
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-27 20:35:18 UTC) #4
Bo Xu
https://codereview.chromium.org/508253003/diff/1/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right): https://codereview.chromium.org/508253003/diff/1/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp#newcode858 core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:858: FX_DWORD bpc = GetValidBpc(); On 2014/08/27 20:26:49, Tom Sepez ...
6 years, 3 months ago (2014-08-27 20:37:24 UTC) #5
Tom Sepez
lgtm
6 years, 3 months ago (2014-08-27 20:53:19 UTC) #6
Bo Xu
6 years, 3 months ago (2014-08-27 21:20:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 405478d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698