|
|
Created:
6 years, 3 months ago by hush (inactive) Modified:
6 years, 3 months ago CC:
chromium-reviews, android-webview-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionAlways close the server in finally block.
BUG=
Committed: https://crrev.com/049e5cdcb26c993f2b94aaa2c4a3267a363d968d
Cr-Commit-Position: refs/heads/master@{#292246}
Patch Set 1 #Patch Set 2 : fix my bug... #Messages
Total messages: 18 (0 generated)
hush@chromium.org changed reviewers: + benm@chromium.org, sgurun@chromium.org
PTAL
LGTM
On 2014/08/27 18:10:14, hush wrote: > PTAL benm@: fyi sgurun@ for review
The CQ bit was checked by hush@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/508233002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was checked by hush@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/508233002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
On 2014/08/27 21:41:06, I haz the power (commit-bot) wrote: > Failed to commit the patch. Doesn't look like there is useful information in https://chromium-status.appspot.com/cq/hush@chromium.org/508233002/20001 What happened to build bot?
The CQ bit was checked by hush@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/508233002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as f2c635834334a690c557045a6da3ed72bd86359d
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/049e5cdcb26c993f2b94aaa2c4a3267a363d968d Cr-Commit-Position: refs/heads/master@{#292246} |