Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 508233002: Always close the server in finally block. (Closed)

Created:
6 years, 3 months ago by hush (inactive)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Always close the server in finally block. BUG= Committed: https://crrev.com/049e5cdcb26c993f2b94aaa2c4a3267a363d968d Cr-Commit-Position: refs/heads/master@{#292246}

Patch Set 1 #

Patch Set 2 : fix my bug... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -33 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 1 chunk +41 lines, -33 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
hush (inactive)
hush@chromium.org changed reviewers: + benm@chromium.org, sgurun@chromium.org
6 years, 3 months ago (2014-08-27 18:10:08 UTC) #1
hush (inactive)
PTAL
6 years, 3 months ago (2014-08-27 18:10:14 UTC) #2
sgurun-gerrit only
LGTM
6 years, 3 months ago (2014-08-27 18:21:27 UTC) #3
hush (inactive)
On 2014/08/27 18:10:14, hush wrote: > PTAL benm@: fyi sgurun@ for review
6 years, 3 months ago (2014-08-27 18:21:47 UTC) #4
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 3 months ago (2014-08-27 18:21:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/508233002/1
6 years, 3 months ago (2014-08-27 18:22:55 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 19:16:20 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 19:29:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/2942)
6 years, 3 months ago (2014-08-27 19:29:01 UTC) #9
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 3 months ago (2014-08-27 20:44:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/508233002/20001
6 years, 3 months ago (2014-08-27 20:45:50 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 21:41:05 UTC) #12
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 21:41:06 UTC) #13
hush (inactive)
On 2014/08/27 21:41:06, I haz the power (commit-bot) wrote: > Failed to commit the patch. ...
6 years, 3 months ago (2014-08-27 22:13:29 UTC) #14
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 3 months ago (2014-08-27 22:14:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/508233002/20001
6 years, 3 months ago (2014-08-27 22:15:56 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f2c635834334a690c557045a6da3ed72bd86359d
6 years, 3 months ago (2014-08-27 22:20:09 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:51 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/049e5cdcb26c993f2b94aaa2c4a3267a363d968d
Cr-Commit-Position: refs/heads/master@{#292246}

Powered by Google App Engine
This is Rietveld 408576698