Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 508223002: Remove Profile dependency from browsing_data_channel_id_helper.cc (Closed)

Created:
6 years, 3 months ago by vabr (Chromium)
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, dbeam+watch-options_chromium.org, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Profile dependency from browsing_data_channel_id_helper.cc The only use of Profile in that file is to get net::URLRequestContextGetter. This CL pulls that out, so that instead of getting a Profile, and asking for URLRequestContextGetter, the affected class gets URLRequestContextGetter directly. This reduces a //chrome dependency to a //net one, and is part of preparations for content settings componentisation. BUG=384873 Committed: https://crrev.com/aaa2520441b77e30fac1ea2952b76d851bb7af51 Cr-Commit-Position: refs/heads/master@{#292354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M chrome/browser/browsing_data/browsing_data_channel_id_helper.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_channel_id_helper.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
vabr (Chromium)
vabr@chromium.org changed reviewers: + bauerb@chromium.org
6 years, 3 months ago (2014-08-27 16:26:38 UTC) #1
vabr (Chromium)
Hi Bernhard :), If you don't mind doing another review, that would be great. (If ...
6 years, 3 months ago (2014-08-27 16:26:38 UTC) #2
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-08-27 16:54:32 UTC) #3
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org
6 years, 3 months ago (2014-08-28 08:34:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/508223002/1
6 years, 3 months ago (2014-08-28 08:35:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0a012fd030ba6fd97982cb5e8ea8c32f73b2f603
6 years, 3 months ago (2014-08-28 09:28:27 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaa2520441b77e30fac1ea2952b76d851bb7af51
Cr-Commit-Position: refs/heads/master@{#292354}

Powered by Google App Engine
This is Rietveld 408576698