Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 508143002: Remove Finch kill switch for PSL matching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed histogram constant from DISABLED to NOT_USED Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
index c5f28c485acccda8bf3f6997c6cc71f5f813fe32..723d4947b3ffe1ed819aa2b3e5db7d7d80b2e76f 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
@@ -533,9 +533,6 @@ class NativeBackendGnomeTest : public testing::Test {
// m.facebook.com password should not get updated. Depending on the argument,
// the credential update is done via UpdateLogin or AddLogin.
void CheckPSLUpdate(UpdateType update_type) {
- password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
-
NativeBackendGnome backend(321);
backend.Init();
@@ -800,8 +797,6 @@ TEST_F(NativeBackendGnomeTest, BasicListLogins) {
TEST_F(NativeBackendGnomeTest, PSLMatchingPositive) {
PasswordForm result;
const GURL kMobileURL("http://m.facebook.com/");
- password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
EXPECT_TRUE(CheckCredentialAvailability(
form_facebook_, kMobileURL, PasswordForm::SCHEME_HTML, &result));
EXPECT_EQ(kMobileURL, result.origin);
@@ -811,8 +806,6 @@ TEST_F(NativeBackendGnomeTest, PSLMatchingPositive) {
// Save a password for www.facebook.com and see it not suggested for
// m-facebook.com.
TEST_F(NativeBackendGnomeTest, PSLMatchingNegativeDomainMismatch) {
- password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
EXPECT_FALSE(CheckCredentialAvailability(
form_facebook_, GURL("http://m-facebook.com/"),
PasswordForm::SCHEME_HTML, NULL));
@@ -820,8 +813,6 @@ TEST_F(NativeBackendGnomeTest, PSLMatchingNegativeDomainMismatch) {
// Test PSL matching is off for domains excluded from it.
TEST_F(NativeBackendGnomeTest, PSLMatchingDisabledDomains) {
- password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
EXPECT_FALSE(CheckCredentialAvailability(
form_google_, GURL("http://one.google.com/"),
PasswordForm::SCHEME_HTML, NULL));
@@ -829,9 +820,6 @@ TEST_F(NativeBackendGnomeTest, PSLMatchingDisabledDomains) {
// Make sure PSL matches aren't available for non-HTML forms.
TEST_F(NativeBackendGnomeTest, PSLMatchingDisabledForNonHTMLForms) {
- password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
-
CheckMatchingWithScheme(PasswordForm::SCHEME_BASIC);
CheckMatchingWithScheme(PasswordForm::SCHEME_DIGEST);
CheckMatchingWithScheme(PasswordForm::SCHEME_OTHER);
« no previous file with comments | « chrome/browser/password_manager/native_backend_gnome_x.cc ('k') | components/password_manager/core/browser/login_database.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698