LayoutTests/fast/dom/idl-dictionary-unittest.html - Issue 508073002: IDL: Add PropertyBag class

Side by Side Diff: LayoutTests/fast/dom/idl-dictionary-unittest.html

Issue 508073002: IDL: Add PropertyBag class (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <script>	3 <script>

4 description('IDL dictionary unittest');	4 description('IDL dictionary unittest');

5	5

6 if (window.internals && internals.dictionaryTest) {	6 if (window.internals && internals.dictionaryTest) {

7 var dictionaryTest = window.internals.dictionaryTest();	7 var dictionaryTest = window.internals.dictionaryTest();

8	8

9 debug('Test for setting an empty dictionary');	9 debug('Test for setting an empty dictionary');

10 dictionaryTest.set({});	10 dictionaryTest.set({});

(...skipping 20 matching lines...) Expand all Loading...
31 booleanOrNullMember: true, doubleOrNullMember: 2.0,	31 booleanOrNullMember: true, doubleOrNullMember: 2.0,

32 stringSequenceMember: ['foo', 'bar', 'baz']});	32 stringSequenceMember: ['foo', 'bar', 'baz']});

33 dict = dictionaryTest.get();	33 dict = dictionaryTest.get();

34 shouldBe('dict.longMember', '3');	34 shouldBe('dict.longMember', '3');

35 shouldBeEqualToString('dict.stringMember', 'modifiedString');	35 shouldBeEqualToString('dict.stringMember', 'modifiedString');

36 shouldBeTrue('dict.booleanOrNullMember');	36 shouldBeTrue('dict.booleanOrNullMember');

37 shouldBe('dict.doubleOrNullMember', '2.0');	37 shouldBe('dict.doubleOrNullMember', '2.0');

38 shouldBe('dict.stringSequenceMember', '["foo", "bar", "baz"]');	38 shouldBe('dict.stringSequenceMember', '["foo", "bar", "baz"]');

39 debug('');	39 debug('');

40	40

41 // FIXME: Following test doesn't pass. Make it pass.

42 /*

43 debug('Test for explicit undefined or null, and missing members');	41 debug('Test for explicit undefined or null, and missing members');

44 dictionaryTest.reset();

45 dictionaryTest.set({longMember: undefined, stringMember: undefined,	42 dictionaryTest.set({longMember: undefined, stringMember: undefined,

46 booleanOrNullMember: null});	43 booleanOrNullMember: null});
	haraken 2014/08/27 16:07:43 Shall we add a test case to pass undefined to bool Shall we add a test case to pass undefined to booleanOrNullMember? Actually we might want to make the test cases more complete. For example: dictionary InternalDictionary { boolean booleanMember; // test for normal type boolean booleanMemberWithDefault = true; // test for normal type with a default value boolean? booleanOrNullMember; // test for nullable type boolean? booleanOrNullMemberWithDefault = true; // test for nullable type with a default value long longMember; // test for other types double doubleMember; // test for other types DOMString stringMember; // test for other types sequence<DOMString> stringSequenceMember; // test for sequence type sequence<DOMString>? stringSequenceOrNullMember; // test for nullable sequence type }; Then you can add test cases that pass null, undefined, a normal value or missing value to each member. You can make the change in a follow-up CL. bashi 2014/08/29 05:21:16 Done. Show quoted text On 2014/08/27 16:07:43, haraken wrote: > > Shall we add a test case to pass undefined to booleanOrNullMember? > > Actually we might want to make the test cases more complete. For example: > > dictionary InternalDictionary { > boolean booleanMember; // test for normal type > boolean booleanMemberWithDefault = true; // test for normal type with a > default value > boolean? booleanOrNullMember; // test for nullable type > boolean? booleanOrNullMemberWithDefault = true; // test for nullable type > with a default value > long longMember; // test for other types > double doubleMember; // test for other types > DOMString stringMember; // test for other types > sequence<DOMString> stringSequenceMember; // test for sequence type > sequence<DOMString>? stringSequenceOrNullMember; // test for nullable > sequence type > }; > > Then you can add test cases that pass null, undefined, a normal value or missing > value to each member. You can make the change in a follow-up CL. Done.
47 dict = dictionaryTest.get();	44 dict = dictionaryTest.get();

48 shouldBeUndefined('dict.longMember');	45 shouldBeUndefined('dict.longMember');

49 shouldBeEqualToString('dict.stringMember', 'defaultStringValue');	46 shouldBeEqualToString('dict.stringMember', 'defaultStringValue');

50 shouldBeNull('dict.booleanOrNullMember');	47 shouldBeNull('dict.booleanOrNullMember');

51 shouldBeUndefined('dict.doubleOrNullMember');	48 shouldBeUndefined('dict.doubleOrNullMember');

52 shouldBeUndefined('dict.stringSequenceMember');	49 shouldBeUndefined('dict.stringSequenceMember');

53 debug('');	50 debug('');

54 */

55	51

56 debug('Test for setting invalid member');	52 debug('Test for setting invalid member');

57 dictionaryTest.set({invalidMember: 'shouldNotBeSet'});	53 dictionaryTest.set({invalidMember: 'shouldNotBeSet'});

58 dict = dictionaryTest.get();	54 dict = dictionaryTest.get();

59 shouldBeUndefined('dict.invalidMember');	55 shouldBeUndefined('dict.invalidMember');

60 debug('');	56 debug('');

61 }	57 }

62 </script>	58 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/bindings/core/v8/PropertyBag.h » ('j') | Source/bindings/core/v8/PropertyBag.h » ('J')