Draw page popups in layout tests

Draw page popups in layout tests

BUG=409503
Committed: https://crrev.com/9b51e6b4070a9a2fc69e9dbe93dd1d9b4e68c3df
Cr-Commit-Position: refs/heads/master@{#295454}

[keishi, 2014-09-01 04:35:54]

CL will be landed in this order
https://codereview.chromium.org/513723003/
https://codereview.chromium.org/508063002/ (this)
https://codereview.chromium.org/530653002/

[keishi, 2014-09-01 04:36:08]

keishi@chromium.org changed reviewers:
+ tkent@chromium.org

[keishi, 2014-09-18 05:04:30]

tkent, PTAL at this next. Thanks.

[tkent, 2014-09-18 05:30:41]

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
File content/shell/renderer/test_runner/web_test_proxy.cc (left):

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
content/shell/renderer/test_runner/web_test_proxy.cc:461: TRACE_EVENT2("shell",
Can you move the TRACE_EVENT2 to CaptureCallback::didCompositeAndReadback?

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
File content/shell/renderer/test_runner/web_test_proxy.cc (right):

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
content/shell/renderer/test_runner/web_test_proxy.cc:68: void
set_popup_position(gfx::Point position) { popup_position_ = position; }
gfx::Point -> const gfx::Point&

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
content/shell/renderer/test_runner/web_test_proxy.cc:355: //CHECK_EQ(0u,
composite_and_readback_callbacks_.size());
Remove this line and the above comment.

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
content/shell/renderer/test_runner/web_test_proxy.cc:581:
capture_callback->set_popup_position(
I think we can write this like:
    capture_callback->set_popup_position(popup->positionRelativeToOwner());
or
   
capture_callback->set_popup_position(static_cast<gfx::Point>(popup->positionRelativeToOwner()));

[keishi, 2014-09-18 05:54:20]

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
File content/shell/renderer/test_runner/web_test_proxy.cc (left):

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
content/shell/renderer/test_runner/web_test_proxy.cc:461: TRACE_EVENT2("shell",
On 2014/09/18 05:30:41, tkent (overloaded) wrote:
> Can you move the TRACE_EVENT2 to CaptureCallback::didCompositeAndReadback?

Done.

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
File content/shell/renderer/test_runner/web_test_proxy.cc (right):

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
content/shell/renderer/test_runner/web_test_proxy.cc:68: void
set_popup_position(gfx::Point position) { popup_position_ = position; }
On 2014/09/18 05:30:40, tkent (overloaded) wrote:
> gfx::Point -> const gfx::Point&

Done.

https://codereview.chromium.org/508063002/diff/80001/content/shell/renderer/t...
content/shell/renderer/test_runner/web_test_proxy.cc:355: //CHECK_EQ(0u,
composite_and_readback_callbacks_.size());
On 2014/09/18 05:30:40, tkent (overloaded) wrote:
> Remove this line and the above comment.

Done.

[tkent, 2014-09-18 06:01:29]

lgtm

https://codereview.chromium.org/508063002/diff/100001/content/shell/renderer/...
File content/shell/renderer/test_runner/web_test_proxy.h (right):

https://codereview.chromium.org/508063002/diff/100001/content/shell/renderer/...
content/shell/renderer/test_runner/web_test_proxy.h:16: #include
"third_party/WebKit/public/platform/WebCompositeAndReadbackAsyncCallback.h"
Move this line to .cc.

[keishi, 2014-09-18 09:14:17]

https://codereview.chromium.org/508063002/diff/100001/content/shell/renderer/...
File content/shell/renderer/test_runner/web_test_proxy.h (right):

https://codereview.chromium.org/508063002/diff/100001/content/shell/renderer/...
content/shell/renderer/test_runner/web_test_proxy.h:16: #include
"third_party/WebKit/public/platform/WebCompositeAndReadbackAsyncCallback.h"
On 2014/09/18 06:01:29, tkent (overloaded) wrote:
> Move this line to .cc.
> 

Done.

https://codereview.chromium.org/508063002/diff/120001/content/shell/renderer/...
File content/shell/renderer/test_runner/web_test_proxy.cc (right):

https://codereview.chromium.org/508063002/diff/120001/content/shell/renderer/...
content/shell/renderer/test_runner/web_test_proxy.cc:597:
DrawSelectionRect(&canvas);
I forgot to call DrawSelectionRect in my previous patch. I wrapped the callback
with DidCapturePixelsAsync. Could you take a look again to see if this is ok?

[tkent, 2014-09-18 09:17:11]

lgtm

[keishi, 2014-09-18 09:44:24]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-09-18 09:44:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/508063002/120001

[commit-bot: I haz the power, 2014-09-18 11:34:51]

Committed patchset #7 (id:120001) as 2eed191dc72e40c319bc2a573973ff7e93a0cccb

[commit-bot: I haz the power, 2014-09-18 11:35:34]

Patchset 7 (id:??) landed as
https://crrev.com/9b51e6b4070a9a2fc69e9dbe93dd1d9b4e68c3df
Cr-Commit-Position: refs/heads/master@{#295454}