Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 507973003: Roll cros_system_api (Closed)

Created:
6 years, 3 months ago by bartfab (slow)
Modified:
6 years, 3 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@d_2_367847_add_get_key_data_ex_call
Project:
chromium
Visibility:
Public.

Description

Roll cros_system_api This pulls in the following changes: * dbus: Add method for cryptohomed GetKeyDataEx * Remove deprecated shill::kPaymentURLProperty * Add a constant for the 'org.freedesktop.DBus' interface. * dbus/service_constants.h: Remove "Cellular.ActivateOverNonCellularNetwork" * Add portal detection failed phase and status to service property BUG=367847 TEST=Everything still compiles Committed: https://crrev.com/f996a06232f02b5e95a1230033268af232c5cfff Cr-Commit-Position: refs/heads/master@{#292366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
bartfab (slow)
bartfab@chromium.org changed reviewers: + pastarmovj@chromium.org
6 years, 3 months ago (2014-08-28 09:37:14 UTC) #1
bartfab (slow)
Hi Julian, Could you stamp this roll please?
6 years, 3 months ago (2014-08-28 09:37:14 UTC) #2
pastarmovj
lgtm
6 years, 3 months ago (2014-08-28 09:37:51 UTC) #3
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 3 months ago (2014-08-28 09:37:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/507973003/1
6 years, 3 months ago (2014-08-28 09:38:29 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 10:34:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8458639198718101656bd1160d20815715423436
6 years, 3 months ago (2014-08-28 11:41:59 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f996a06232f02b5e95a1230033268af232c5cfff
Cr-Commit-Position: refs/heads/master@{#292366}

Powered by Google App Engine
This is Rietveld 408576698