Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 507953002: closure: make tracking script cwd-independent. (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

closure: make tracking script cwd-independent. R=vitalyp@chromium.org,tbreisacher@chromium.org BUG=393873 TEST=cd third_party/closure_compiler && ./tools/compile_coverage.py NOTRY=true Committed: https://crrev.com/2e2ec7c150110d82d2134050724d254237c9fe44 Cr-Commit-Position: refs/heads/master@{#292204}

Patch Set 1 : simpler #

Patch Set 2 : make file paths absolute + incorporate .gitignore #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M third_party/closure_compiler/tools/compile_coverage.py View 1 5 chunks +27 lines, -20 lines 2 comments Download

Messages

Total messages: 14 (0 generated)
Dan Beam
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-27 03:16:38 UTC) #1
Dan Beam
6 years, 3 months ago (2014-08-27 03:16:43 UTC) #2
Tyler Breisacher (Chromium)
lgtm
6 years, 3 months ago (2014-08-27 06:30:58 UTC) #3
Vitaly Pavlenko
lgtm
6 years, 3 months ago (2014-08-27 16:38:13 UTC) #4
Dan Beam
Patchset #2 (id:40001) has been deleted
6 years, 3 months ago (2014-08-27 18:51:52 UTC) #5
Dan Beam
Patchset #2 (id:60001) has been deleted
6 years, 3 months ago (2014-08-27 18:53:39 UTC) #6
Dan Beam
tbreisacher@: ptal -- retouched the code to work with absolute file paths and ignore stuff ...
6 years, 3 months ago (2014-08-27 18:57:10 UTC) #7
Tyler Breisacher (Chromium)
https://chromiumcodereview.appspot.com/507953002/diff/80001/third_party/closure_compiler/tools/compile_coverage.py File third_party/closure_compiler/tools/compile_coverage.py (right): https://chromiumcodereview.appspot.com/507953002/diff/80001/third_party/closure_compiler/tools/compile_coverage.py#newcode38 third_party/closure_compiler/tools/compile_coverage.py:38: _IGNORE_DIRS = tuple(map(_FROM_SRC, map(lambda p: p[1:], _GIT_IGNORE))) Why do ...
6 years, 3 months ago (2014-08-27 19:01:27 UTC) #8
Dan Beam
https://chromiumcodereview.appspot.com/507953002/diff/80001/third_party/closure_compiler/tools/compile_coverage.py File third_party/closure_compiler/tools/compile_coverage.py (right): https://chromiumcodereview.appspot.com/507953002/diff/80001/third_party/closure_compiler/tools/compile_coverage.py#newcode38 third_party/closure_compiler/tools/compile_coverage.py:38: _IGNORE_DIRS = tuple(map(_FROM_SRC, map(lambda p: p[1:], _GIT_IGNORE))) On 2014/08/27 ...
6 years, 3 months ago (2014-08-27 19:03:59 UTC) #9
Tyler Breisacher (Chromium)
(still lgtm, just curious)
6 years, 3 months ago (2014-08-27 19:04:12 UTC) #10
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 3 months ago (2014-08-27 19:13:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/507953002/80001
6 years, 3 months ago (2014-08-27 19:14:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:80001) as 53f19adc5f0aae1172620fa2897d9b330fb5697e
6 years, 3 months ago (2014-08-27 19:15:23 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:24 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2e2ec7c150110d82d2134050724d254237c9fe44
Cr-Commit-Position: refs/heads/master@{#292204}

Powered by Google App Engine
This is Rietveld 408576698