chrome/app/BUILD.gn - Issue 507913002: Finish converting chrome_strings target to use qualified paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/BUILD.gn

Issue 507913002: Finish converting chrome_strings target to use qualified paths. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/BUILD.gn

diff --git a/chrome/app/BUILD.gn b/chrome/app/BUILD.gn

index b226380bc08f6900a9cfeb20f46a3db3d8b3baef..3113d78bd02acb4451e10f9181b52c93ce3b575e 100644

--- a/chrome/app/BUILD.gn

+++ b/chrome/app/BUILD.gn

@@ -9,6 +9,7 @@ import("//tools/grit/grit_rule.gni")

grit("generated_resources") {

source = "generated_resources.grd"

output_dir = "$root_gen_dir/chrome"

+ use_qualified_include = true

outputs = [

"grit/generated_resources.h",

"generated_resources_am.pak",

@@ -96,6 +97,7 @@ source_set("generated_resources_map") {

grit("google_chrome_strings") {

source = "google_chrome_strings.grd"

output_dir = "$root_gen_dir/chrome"

+ use_qualified_include = true

outputs = [

"grit/google_chrome_strings.h",

"google_chrome_strings_am.pak",

@@ -160,6 +162,7 @@ grit("google_chrome_strings") {

grit("chromium_strings") {

source = "chromium_strings.grd"

output_dir = "$root_gen_dir/chrome"

+ use_qualified_include = true

outputs = [

"grit/chromium_strings.h",

"chromium_strings_am.pak",

« no previous file with comments | « no previous file | chrome/app/resources/BUILD.gn » ('j') | no next file with comments »