Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 507913002: Finish converting chrome_strings target to use qualified paths. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, asanka, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, zea+watch_chromium.org, posciak+watch_chromium.org, browser-components-watch_chromium.org, stuartmorgan+watch_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, rlp+watch_chromium.org, groby+spellwatch_chromium.org, kalyank, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, haitaol+watch_chromium.org, rouslan+spellwatch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, Michael van Ouwerkerk, maniscalco+watch_chromium.org, tfarina, mcasas+watch_chromium.org, estade+watch_chromium.org, wjia+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Finish converting chrome_strings target to use qualified paths. BUG=401588 Committed: https://crrev.com/aeddd327d27e99173c218bcef00422cd0d6cef30 Cr-Commit-Position: refs/heads/master@{#292111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -44 lines) Patch
M chrome/app/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/app/resources/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/browser_version.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_quota_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_shelf.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_internal_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/midi_permission_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/prefs_syncable_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/hung_plugin_tab_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/conflicting_module_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/critical_notification_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/proxy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/search_engine_manager_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/set_as_default_browser_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/system_info_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
thestig@chromium.org changed reviewers: + thakis@chromium.org
6 years, 3 months ago (2014-08-27 02:45:43 UTC) #1
Lei Zhang
6 years, 3 months ago (2014-08-27 02:45:44 UTC) #2
Nico
lgtm Nice!
6 years, 3 months ago (2014-08-27 03:38:53 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-27 05:49:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/507913002/1
6 years, 3 months ago (2014-08-27 05:49:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 4205f6c9f59f2315c6dd36ccf20f673f6422165b
6 years, 3 months ago (2014-08-27 06:58:49 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:17 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aeddd327d27e99173c218bcef00422cd0d6cef30
Cr-Commit-Position: refs/heads/master@{#292111}

Powered by Google App Engine
This is Rietveld 408576698