Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 507893002: Revert of Improve the ScopedHandle verifier. (Closed)

Created:
6 years, 3 months ago by tonyg
Modified:
6 years, 3 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve the ScopedHandle verifier. (patchset #1 of https://codereview.chromium.org/506013004/) Reason for revert: All windows perf bots (official builds) crashing. http://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/73062/steps/generate_telemetry_profiles/logs/stdio ChildEBP RetAddr 0022f7c0 6a3ffa19 chrome_69c90000!base::debug::BreakDebugger+0x10 0022f830 6a400622 chrome_69c90000!CheckIsChromeSxSProcess+0x26 0022f834 6a400d52 chrome_69c90000!InstallUtil::IsChromeSxSProcess+0x16 0022f83c 6a400c29 chrome_69c90000!BrowserDistribution::GetSpecificDistribution+0x3b 0022f844 6a3fe166 chrome_69c90000!BrowserDistribution::GetDistribution+0x7 0022f930 6a3fe11d chrome_69c90000!`anonymous namespace'::GetChromeChannelInternal+0x2c 0022f948 6a092c6c chrome_69c90000!GoogleUpdateSettings::GetChromeChannel+0x21 0022f9b4 6a08f70f chrome_69c90000!chrome::VersionInfo::GetChannel+0x60 0022f9b8 6a08f65a chrome_69c90000!`anonymous namespace'::UseHooks+0x5 0022f9dc 6a08eb5a chrome_69c90000!InstallCloseHandleHooks+0x15 0022fa20 00fb7623 chrome_69c90000!ChromeMain+0x3e 0022fab0 00fb7026 chrome!MainDllLoader::Launch+0x15f 0022faf4 00fd936a chrome!wWinMain+0x5a 0022fb40 766e338a chrome!__tmainCRTStartup+0xfd WARNING: Stack unwind information not available. Following frames may be wrong. 0022fb4c 76f99f72 kernel32!BaseThreadInitThunk+0x12 0022fb8c 76f99f45 ntdll!RtlInitializeExceptionChain+0x63 0022fba4 00000000 ntdll!RtlInitializeExceptionChain+0x36 Original issue's description: > Improve the ScopedHandle verifier. > > 1. Automate the selection of the proper channel to enable the verifier. > Now the code is enabled at runtime. > > 2. Switch to a hash_map to track handles. > > 3. Intercept CloseHandle to detect the code that is closing handles owned > by ScopedHandles. The initial implementation only covers chrome.exe/dll, > but the plan is to extend that in the future to all modules loaded in the > process. > > BUG=362176 > R=cpu@chromium.org > R=sky@chromium.org > > See https://codereview.chromium.org/490043002/ for the actual review. > > TBR=cpu@chromium.org > TBR=sky@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/c928d0383db43f2f4baf8f9b24ed7454bf7eda64 TBR=cpu@chromium.org,sky@chromium.org,rvargas@chromium.org NOTREECHECKS=true NOTRY=true BUG=362176 Committed: https://crrev.com/cf244d180857d5df17b96734e976631024526930 Cr-Commit-Position: refs/heads/master@{#292047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -260 lines) Patch
M base/win/scoped_handle.h View 3 chunks +6 lines, -13 lines 0 comments Download
M base/win/scoped_handle.cc View 4 chunks +7 lines, -92 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/chrome_main.cc View 3 chunks +0 lines, -4 lines 0 comments Download
D chrome/app/close_handle_hook_win.h View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/app/close_handle_hook_win.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M chrome/chrome_dll.gypi View 4 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tonyg
Created Revert of Improve the ScopedHandle verifier.
6 years, 3 months ago (2014-08-27 00:11:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/507893002/1
6 years, 3 months ago (2014-08-27 00:13:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as f7d58c2bf19499ed76c28c983baa3f9325a5fadc
6 years, 3 months ago (2014-08-27 00:14:36 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf244d180857d5df17b96734e976631024526930
Cr-Commit-Position: refs/heads/master@{#292047}

Powered by Google App Engine
This is Rietveld 408576698