[Blink-Worker] WorkerThread fires idleHandler only at the end of processing all tasks.

Source/core/workers/WorkerThread.h

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 17 matching lines @@
 #define WorkerThread_h
 
 #include "core/dom/ExecutionContextTask.h"
 #include "core/frame/csp/ContentSecurityPolicy.h"
 #include "core/workers/WorkerGlobalScope.h"
 #include "platform/SharedTimer.h"
 #include "platform/WebThreadSupportingGC.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "wtf/Forward.h"
 #include "wtf/MessageQueue.h"
+#include "wtf/Noncopyable.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace blink {
 class WebWaitableEvent;
 }
 
 namespace blink {
 
     class KURL;
     class WorkerGlobalScope;
     class WorkerInspectorController;
     class WorkerLoaderProxy;
     class WorkerReportingProxy;
     class WorkerSharedTimer;
     class WorkerThreadShutdownFinishTask;
     class WorkerThreadStartupData;
     class WorkerThreadTask;
 
     enum WorkerThreadStartMode { DontPauseWorkerGlobalScopeOnStart, PauseWorkerGlobalScopeOnStart };
 
 
     class WorkerThread : public RefCounted<WorkerThread> {
+
+        class WorkerThreadTask : public blink::WebThread::Task {

[jochen (gone - plz use gerrit), 2014/10/14 13:46:03]

nit. move down to the provide section.

it's also enough to forward declare the class (just class WorkerThreadTask;)

+            WTF_MAKE_NONCOPYABLE(WorkerThreadTask); WTF_MAKE_FAST_ALLOCATED;
+        public:
+            static PassOwnPtr<WorkerThreadTask> create(WorkerThread&
+                , PassOwnPtr<ExecutionContextTask>, bool);
+
+            virtual ~WorkerThreadTask() { }
+            virtual void run() OVERRIDE;
+
+            void setIsIdleHandlerTask(bool isIdleHandlerTask) { m_isIdleHandlerTask = isIdleHandlerTask; }
+            bool isIdleHandlerTask() const { return m_isIdleHandlerTask; }
+
+        private:
+            WorkerThreadTask(WorkerThread&
+                , PassOwnPtr<ExecutionContextTask>, bool);
+
+            WorkerThread& m_workerThread;
+            OwnPtr<ExecutionContextTask> m_task;
+            bool m_isInstrumented;
+            bool m_isIdleHandlerTask;
+        };
+
     public:
         virtual ~WorkerThread();
 
         virtual void start();
         virtual void stop();
 
         // Can be used to wait for this worker thread to shut down.
         // (This is signalled on the main thread, so it's assumed to be waited on the worker context thread)
         blink::WebWaitableEvent* shutdownEvent() { return m_shutdownEvent.get(); }
 
@@ skipping 20 matching lines @@
 
         // Number of active worker threads.
         static unsigned workerThreadCount();
 
         PlatformThreadId platformThreadId() const;
 
         void interruptAndDispatchInspectorCommands();
         void setWorkerInspectorController(WorkerInspectorController*);
 
     protected:
+        int decrementAndReturnTaskCount();
+        void queueUpIdleHandlerNow(long long delayMs);
+        int taskCount() { return m_tasksCount; }
+
         WorkerThread(WorkerLoaderProxy&, WorkerReportingProxy&, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);
 
         // Factory method for creating a new worker context for the thread.
         virtual PassRefPtrWillBeRawPtr<WorkerGlobalScope> createWorkerGlobalScope(PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>) = 0;
 
         virtual void postInitialize() { }
 
     private:
         friend class WorkerSharedTimer;
         friend class WorkerThreadShutdownFinishTask;
@@ skipping 20 matching lines @@
         Mutex m_threadCreationMutex;
         RefPtrWillBePersistent<WorkerGlobalScope> m_workerGlobalScope;
         OwnPtrWillBePersistent<WorkerThreadStartupData> m_startupData;
 
         // Used to signal thread shutdown.
         OwnPtr<blink::WebWaitableEvent> m_shutdownEvent;
 
         // Used to signal thread termination.
         OwnPtr<blink::WebWaitableEvent> m_terminationEvent;
 
+        bool m_IdleHandlerTaskPosted;
+        volatile int m_tasksCount;
+
         // FIXME: This has to be last because of crbug.com/401397 - the
         // WorkerThread might get deleted before it had a chance to properly
         // shut down. By deleting the WebThread first, we can guarantee that
         // no pending tasks on the thread might want to access any of the other
         // members during the WorkerThread's destruction.
         OwnPtr<WebThreadSupportingGC> m_thread;
     };
 
 } // namespace blink
 
 #endif // WorkerThread_h