Remove some duplicated code, and make rsa_key_nss.cc more closely match rsa_key_openssl.cc.

Remove some duplicated code, and make rsa_key_nss.cc more closely match rsa_key_openssl.cc.

BUG=407874, 407861
Committed: https://crrev.com/cb7fed97554f1fa65a7f05ff616667df530f9220
Cr-Commit-Position: refs/heads/master@{#292267}

[eroman, 2014-08-26 23:30:11]

eroman@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2014-08-27 17:14:09]

Hrm, a little weird, having trouble wrapping my head around the use of the API

https://codereview.chromium.org/507873002/diff/1/content/child/webcrypto/nss/...
File content/child/webcrypto/nss/rsa_key_nss.cc (right):

https://codereview.chromium.org/507873002/diff/1/content/child/webcrypto/nss/...
content/child/webcrypto/nss/rsa_key_nss.cc:78: rsa_algorithm,
Is the assumption that |rsa_algorithm| holds label / saltLength, but not
hash_algorithm?

[eroman, 2014-08-27 17:27:38]

https://codereview.chromium.org/507873002/diff/1/content/child/webcrypto/nss/...
File content/child/webcrypto/nss/rsa_key_nss.cc (right):

https://codereview.chromium.org/507873002/diff/1/content/child/webcrypto/nss/...
content/child/webcrypto/nss/rsa_key_nss.cc:78: rsa_algorithm,
On 2014/08/27 17:14:09, Ryan Sleevi wrote:
> Is the assumption that |rsa_algorithm| holds label / saltLength, but not
> hash_algorithm?

The containing function (CreateRsaHashedPublicKeyAlgorithm) is responsible for
creating the Key.algorithm object given an existing NSS key, and the
"rsa_algorithm" and "hash_algorithm".

These two parameters (rsa_algorithm and hash_algorithm) correspond with the
properties common to both RsaHashedImportParams and RsaHashedKeyGenParams, which
are the two possible entry points for creating the key (unwrapping would also be
given an RsaHashedImportParams).

Note that "rsa_algorithm" is the ID for the algorithm, and not a generic
WebCryptoAlgorithm object. I think this is where the confusion lies.

Therefore label/saltLength are not applicable, as those are operation parameters
and not key creation parameters (label is a parameter to encrypt/decrypt for
RSA-OAEP, and saltLen is a parameter to sign/verify RSA-PSS).

tl;dr; Before what was happening is a generic "key creation algorithm" was being
passed in, and then there was a switch statement (GetInnerHashAlgorithm) to type
cast it and extract the hash. With this re-organization I have removed the
generic switch, and instead ImportKey() and GenerateKey() are responsible for
extracting the hash and passing it into this function (the parameters type is
well known at those entry points).

This matches the organization in the OpenSSL code, since I want to remove big
switch statements as much as possible.

[Ryan Sleevi, 2014-08-27 17:29:38]

Ah, right, NSS exposes them as PKCS#11 op params.

In that case, LGTM

[eroman, 2014-08-27 18:53:59]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-27 18:55:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/507873002/1

[commit-bot: I haz the power, 2014-08-27 20:22:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 20:22:09]

Failed to commit the patch.

[eroman, 2014-08-27 20:27:08]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-27 20:27:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/507873002/1

[commit-bot: I haz the power, 2014-08-27 20:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 20:29:00]

Failed to commit the patch.

[eroman, 2014-08-27 22:19:59]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-27 22:21:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/507873002/20001

[commit-bot: I haz the power, 2014-08-27 23:43:11]

Committed patchset #2 (id:20001) as 0d92f5c203ecb634ba0bb5501a0ce13e420c97e4

[commit-bot: I haz the power, 2014-09-10 02:55:37]

Patchset 2 (id:??) landed as
https://crrev.com/cb7fed97554f1fa65a7f05ff616667df530f9220
Cr-Commit-Position: refs/heads/master@{#292267}