Issue 507853002: Removes unconditionally added chrome_run

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 507853002: Removes unconditionally added chrome_run (Closed)

Created:
6 years, 3 months ago by sky

Modified:
6 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Removes unconditionally added chrome_run It's no longer necessary as I fixed the underlying bug in the recipe side. BUG=407419 TEST=none R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/18047c97ad20c3f393560a904d452c10fb222a70 Cr-Commit-Position: refs/heads/master@{#292043}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	chrome/chrome_exe.gypi	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/507853002/1

6 years, 3 months ago (2014-08-26 22:27:39 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...

6 years, 3 months ago (2014-08-26 23:44:42 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as 1cd0e9d4461b33d1bffafce7011d259885c66004

6 years, 3 months ago (2014-08-27 00:01:58 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:47:49 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/18047c97ad20c3f393560a904d452c10fb222a70
Cr-Commit-Position: refs/heads/master@{#292043}