Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 507833002: Revert of Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages (Closed)

Created:
6 years, 3 months ago by Jeffrey Yasskin
Modified:
6 years, 3 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages (patchset #2 of https://codereview.chromium.org/502233002/) Reason for revert: The fix (https://src.chromium.org/viewvc/blink?revision=180854) should be included by the Blink roll in http://crrev.com/ecb9875276ccd. Original issue's description: > Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages > > BUG=407396 > NOTRY=true > TBR=ager@chromium.org > NOTREECHECKS=true > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/8da39ba TBR=ager@chromium.org NOTREECHECKS=true NOTRY=true BUG=407396 Committed: https://crrev.com/7233c9d809f5ef5a2cd22badc57a667ab305d055 Cr-Commit-Position: refs/heads/master@{#291983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jeffrey Yasskin
Created Revert of Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages
6 years, 3 months ago (2014-08-26 21:12:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/507833002/1
6 years, 3 months ago (2014-08-26 21:13:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as d02e7eac5bdc39abfe9b6601b53212ac6c5700b8
6 years, 3 months ago (2014-08-26 21:15:59 UTC) #3
Mads Ager (chromium)
On 2014/08/26 at 21:15:59, commit-bot wrote: > Committed patchset #1 (1) as d02e7eac5bdc39abfe9b6601b53212ac6c5700b8 LGTM, thanks!
6 years, 3 months ago (2014-08-27 06:20:27 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:45:40 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7233c9d809f5ef5a2cd22badc57a667ab305d055
Cr-Commit-Position: refs/heads/master@{#291983}

Powered by Google App Engine
This is Rietveld 408576698