Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 507783003: Add GetActiveScreen to DisplayInfoProvider (Closed)

Created:
6 years, 3 months ago by tmpsantos
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

This removes an ash dependency from the system.display API in order to move it to extensions/. As a side effect, we got rid of #ifdefs on system_info_api.cc BUG=392842 Committed: https://crrev.com/567bb9246c5fac1377761ab1b30b0b6db2b78ebf Cr-Commit-Position: refs/heads/master@{#292373}

Patch Set 1 : #

Messages

Total messages: 12 (0 generated)
tmpsantos
thiago.santos@intel.com changed reviewers: + hongbo.min@intel.com, jamescook@chromium.org
6 years, 3 months ago (2014-08-27 12:12:00 UTC) #1
tmpsantos
Please review. This is needed in order to move this API to extensions/ without bringing ...
6 years, 3 months ago (2014-08-27 12:12:00 UTC) #2
tmpsantos
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-27 12:12:17 UTC) #3
tmpsantos
thiago.santos@intel.com changed reviewers: + yoz@chromium.org
6 years, 3 months ago (2014-08-27 14:33:15 UTC) #4
tmpsantos
6 years, 3 months ago (2014-08-27 14:33:15 UTC) #5
James Cook
LGTM but this needs a better CL description before landing. You should indicate that it ...
6 years, 3 months ago (2014-08-27 16:03:15 UTC) #6
Yoyo Zhou
On 2014/08/27 16:03:15, James Cook wrote: > LGTM but this needs a better CL description ...
6 years, 3 months ago (2014-08-27 19:12:07 UTC) #7
tmpsantos
On 2014/08/27 19:12:07, Yoyo Zhou wrote: > On 2014/08/27 16:03:15, James Cook wrote: > > ...
6 years, 3 months ago (2014-08-28 12:38:05 UTC) #8
tmpsantos
The CQ bit was checked by thiago.santos@intel.com
6 years, 3 months ago (2014-08-28 12:38:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thiago.santos@intel.com/507783003/20001
6 years, 3 months ago (2014-08-28 12:39:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 88d628a042b25f3c0890d6ffdb63481ed64b9f86
6 years, 3 months ago (2014-08-28 13:30:11 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/567bb9246c5fac1377761ab1b30b0b6db2b78ebf
Cr-Commit-Position: refs/heads/master@{#292373}

Powered by Google App Engine
This is Rietveld 408576698