Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: public/web/WebSharedWorkerClient.h

Issue 50773002: Introduce WebWorkerPermissionClientProxy to deprecate WorkerAllowMainThreadBridge (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: updated comments, minor code fix Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/web/WebFrameClient.h ('k') | public/web/WebWorkerPermissionClientProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebSharedWorkerClient.h
diff --git a/public/web/WebSharedWorkerClient.h b/public/web/WebSharedWorkerClient.h
index d2c8a2aadfaad858f6ba2cd9ad60c6bf3a76bb6f..db40ad0b2d04ef281ff891c7c91f886ee648e93e 100644
--- a/public/web/WebSharedWorkerClient.h
+++ b/public/web/WebSharedWorkerClient.h
@@ -37,8 +37,10 @@
namespace WebKit {
class WebNotificationPresenter;
+class WebSecurityOrigin;
class WebString;
class WebWorker;
+class WebWorkerPermissionClientProxy;
// Provides an interface back to the in-page script object for a worker.
// All functions are expected to be called back on the thread that created
@@ -52,9 +54,17 @@ public:
// is owned by the object implementing WebCommonWorkerClient.
virtual WebNotificationPresenter* notificationPresenter() = 0;
- // Called on the main webkit thread in the worker process during initialization.
+ // Called on the main webkit thread in the worker process during
+ // initialization.
virtual WebApplicationCacheHost* createApplicationCacheHost(WebApplicationCacheHostClient*) = 0;
+ // Called on the main webkit thread in the worker process during
+ // initialization.
+ // WebWorkerPermissionClientProxy should not retain the given
+ // WebSecurityOrigin, as the proxy instance is passed to worker thread
+ // while WebSecurityOrigin is not thread safe.
+ virtual WebWorkerPermissionClientProxy* createWorkerPermissionClientProxy(const WebSecurityOrigin&) { return 0; }
+
virtual void dispatchDevToolsMessage(const WebString&) { }
virtual void saveDevToolsAgentState(const WebString&) { }
« no previous file with comments | « public/web/WebFrameClient.h ('k') | public/web/WebWorkerPermissionClientProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698