Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 507673003: [NaCl SDK] Update getos.py tests to match new behaviour. (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 3 months ago
Reviewers:
Matt Giuca, binji
CC:
chromium-reviews, binji+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/5f35ed44b90c99e00eb67f1a5fea4f81a78269fc Cr-Commit-Position: refs/heads/master@{#291926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/tools/tests/getos_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam Clegg
sbc@chromium.org changed reviewers: + mgiuca@chromium.org
6 years, 3 months ago (2014-08-26 16:05:10 UTC) #1
Sam Clegg
6 years, 3 months ago (2014-08-26 16:05:11 UTC) #2
binji
binji@chromium.org changed reviewers: + binji@chromium.org
6 years, 3 months ago (2014-08-26 17:14:53 UTC) #3
binji
lgtm
6 years, 3 months ago (2014-08-26 17:14:53 UTC) #4
Sam Clegg
Committed patchset #1 to pending queue manually as 412940d (presubmit successful).
6 years, 3 months ago (2014-08-26 17:28:55 UTC) #5
Matt Giuca
lgtm crap! Sorry I missed this and thanks for fixing.
6 years, 3 months ago (2014-08-26 23:40:58 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f35ed44b90c99e00eb67f1a5fea4f81a78269fc
Cr-Commit-Position: refs/heads/master@{#291926}

Powered by Google App Engine
This is Rietveld 408576698