Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 507653005: Fixes the fling and closest state logic in HomeCardGestureManager. (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
oshima, sadrul
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixes the fling and closest state logic in HomeCardGestureManager. The weak fling should be handled and end the gesture session for issue 406197. Also, fling handling turns out to check closest state instead of last_state_. Otherwise there could be a chance to enter an inconsistent state from the visual. Also, the area of "closest to minimized" is too small, so I put 50px static height for this. BUG=406197, 407890 R=oshima@chromium.org TEST=athena_unittests, manually Committed: https://crrev.com/efba177008e6b876a085a96426c63566b1efc657 Cr-Commit-Position: refs/heads/master@{#292284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M athena/home/home_card_gesture_manager.cc View 2 chunks +16 lines, -23 lines 0 comments Download
M athena/home/home_card_gesture_manager_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M athena/home/home_card_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jun Mukai
6 years, 3 months ago (2014-08-27 00:02:07 UTC) #1
Jun Mukai
mukai@chromium.org changed reviewers: + oshima@chromium.org - sadrul@chromium.org
6 years, 3 months ago (2014-08-27 21:20:16 UTC) #2
Jun Mukai
oshima, could you take a look?
6 years, 3 months ago (2014-08-27 21:20:26 UTC) #3
sadrul
sadrul@chromium.org changed reviewers: + sadrul@chromium.org
6 years, 3 months ago (2014-08-27 23:19:54 UTC) #4
sadrul
LGTM Sorry about the delay
6 years, 3 months ago (2014-08-27 23:19:54 UTC) #5
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 3 months ago (2014-08-27 23:29:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/507653005/1
6 years, 3 months ago (2014-08-27 23:31:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0f24d736081745ea3348cb7edb7adc2d02757e7b
6 years, 3 months ago (2014-08-28 00:39:42 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efba177008e6b876a085a96426c63566b1efc657
Cr-Commit-Position: refs/heads/master@{#292284}

Powered by Google App Engine
This is Rietveld 408576698