DescriptionRemove safe-browsing code to fix up injected prefixes.
An older implementation of the safe-browsing database code injected
prefixes when receiving full hashes, due to an incorrect reading of how
full-hash matches should happen. Current code checks the full hashes
and prefixes independently, so the duplicate prefixes are no longer
generated. This code removed duplicate prefixes found in existing
databases. 99.99% of runs over the past two weeks have not removed any
such duplicate prefixes.
In the current code hitting a full hash has the same end result as
hitting a prefix, so the primary downside of removing this code is
slight excess storage. Insofar as full hashes are deleted by sub, there
may be stale prefixes left behind. The stale prefixes will be deleted
when the chunk in question is deleted. The result may be a small number
of unexpected gethash requests which will return misses (and thus not
affect the browsing experience other than adding a little latency).
BUG=361248
Committed: https://crrev.com/6434e337b1c0eba3c30d497d7d1a785f4a3d1e5b
Cr-Commit-Position: refs/heads/master@{#292019}
Patch Set 1 #Patch Set 2 : Revert original CL more thoroughly. #
Messages
Total messages: 9 (0 generated)
|