Issue 507653002: [Guest mode] Make sure chrome://thumbnails doesn't crash.

Issue 507653002: [Guest mode] Make sure chrome://thumbnails doesn't crash. (Closed)

Created:
6 years, 3 months ago by Mathieu

Modified:
6 years, 3 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Mike Lerman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[Guest mode] Make sure chrome://thumbnails doesn't crash. Checking for existence of TopSites. BUG=407527 Committed: https://crrev.com/22180a632f46aa20015567bc274d0771419114a8 Cr-Commit-Position: refs/heads/master@{#292010}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/thumbnails/thumbnail_list_source.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

Mathieu

mathp@chromium.org changed reviewers: + mlerman@chromium.org, thestig@chromium.org

6 years, 3 months ago (2014-08-26 13:36:13 UTC) #1

Mathieu

mathp@chromium.org changed reviewers: - mlerman@chromium.org

6 years, 3 months ago (2014-08-26 13:37:34 UTC) #2

Mathieu

Hi Lei, This fixes a crash seen in the wild with Guest mode. Thanks!

6 years, 3 months ago (2014-08-26 13:38:23 UTC) #3

Lei Zhang

lgtm You can optionally save the pointer returned by GetTopSites() instead of calling it twice.

6 years, 3 months ago (2014-08-26 20:39:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/507653002/1

6 years, 3 months ago (2014-08-26 20:43:49 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (1) as 113234a34972683b767d35e957a161c1eca8efbe

6 years, 3 months ago (2014-08-26 22:43:59 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:46:40 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/22180a632f46aa20015567bc274d0771419114a8
Cr-Commit-Position: refs/heads/master@{#292010}