Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 507643002: Bring back lost gamepad_seqlock_unittest. (Closed)

Created:
6 years, 3 months ago by timvolodine
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Bring back lost gamepad_seqlock_unittest. Currently gamepad_seqlock_unittest.cc is not included in content_tests.gypi. Also GamepadSeqLock was renamed to OneWriterSeqlLock some time ago as it is used not only by the gamepad. To rectify this situation this patch does the following: - replace references to GamepadSeqLock - include the unittest in content_tests.gypi Committed: https://crrev.com/553f87c99cb34e0e95c5a9bf740537ed74163a2e Cr-Commit-Position: refs/heads/master@{#292878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -105 lines) Patch
D content/common/gamepad_seqlock_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
A + content/common/one_writer_seqlock_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
timvolodine
timvolodine@chromium.org changed reviewers: + scottmg@chromium.org
6 years, 3 months ago (2014-08-26 13:52:13 UTC) #1
timvolodine
6 years, 3 months ago (2014-08-26 13:52:13 UTC) #2
scottmg
scottmg@chromium.org changed reviewers: + bajones@chromium.org
6 years, 3 months ago (2014-08-26 17:02:18 UTC) #3
scottmg
lgtm, thanks. +bajones fyi
6 years, 3 months ago (2014-08-26 17:02:18 UTC) #4
timvolodine
+ jam: as content/common owner
6 years, 3 months ago (2014-08-29 17:30:58 UTC) #6
timvolodine
+ jochen for content/common
6 years, 3 months ago (2014-09-01 11:52:59 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-01 13:17:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/507643002/1
6 years, 3 months ago (2014-09-01 15:03:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 18687fc9d1fd73bb9d7dd1b5839536e276d32d02
6 years, 3 months ago (2014-09-01 16:00:04 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:17:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/553f87c99cb34e0e95c5a9bf740537ed74163a2e
Cr-Commit-Position: refs/heads/master@{#292878}

Powered by Google App Engine
This is Rietveld 408576698