Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 507613002: Fixed inlining of constant values (Closed)

Created:
6 years, 3 months ago by Toon Verwaest
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fixed inlining of constant values Use CopyToRepresentation to elide HForceRepresentation of HConstant BUG=v8:3529 LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -32 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M src/property-details.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/property-details-inl.h View 1 chunk +0 lines, -12 lines 0 comments Download
A + test/mjsunit/regress/regress-force-constant-representation.js View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
verwaest@chromium.org changed reviewers: + bmeurer@chromium.org
6 years, 3 months ago (2014-08-26 11:31:26 UTC) #1
Toon Verwaest
PTAL
6 years, 3 months ago (2014-08-26 11:31:27 UTC) #2
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-08-26 11:32:25 UTC) #3
Toon Verwaest
6 years, 3 months ago (2014-08-26 11:34:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23397 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698