Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 507573002: webui: add a gyp file for ui/webui/resources/js/cr/ui and build the pre-compiled (Closed)

Created:
6 years, 4 months ago by Dan Beam
Modified:
6 years, 3 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, oshima+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

webui: add a gyp file for ui/webui/resources/js/cr/ui and build the pre-compiled focus_manager.js with it. R=arv@chromium.org BUG=393873 NOTRY=true Committed: https://crrev.com/e05135fb7d8344be193ddcf47007946e634c24d4 Cr-Commit-Position: refs/heads/master@{#293590}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M third_party/closure_compiler/compiled_resources.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A + ui/webui/resources/js/cr/ui/compiled_resources.gyp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dan Beam
6 years, 4 months ago (2014-08-26 04:56:19 UTC) #1
Dan Beam
ping arv@
6 years, 3 months ago (2014-08-27 06:23:36 UTC) #2
arv (Not doing code reviews)
LGTM
6 years, 3 months ago (2014-09-02 16:41:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/507573002/1
6 years, 3 months ago (2014-09-03 18:45:49 UTC) #5
commit-bot: I haz the power
Failed to apply patch for third_party/closure_compiler/compiled_resources.gyp: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-03 23:06:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/507573002/40001
6 years, 3 months ago (2014-09-05 23:01:57 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 3d966366cbae10d8f95b6c80fd62dc5c37da5f16
6 years, 3 months ago (2014-09-05 23:04:18 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e05135fb7d8344be193ddcf47007946e634c24d4
Cr-Commit-Position: refs/heads/master@{#293590}

Powered by Google App Engine
This is Rietveld 408576698