Removes usage of aura::Window from Node

Removes usage of aura::Window from Node

Each Node no longer creates an aura::Window. Instead RootViewManager
creates a single aura::Window that is responsible for drawing the
entire scene. RootViewManager is told when to redraw certain
areas. When RootViewManager needs to paint is paints the whole
tree.

At some point RootViewManager won't creat an aura::Window at all,
instead it'll take to the surface manager and create the frame data
for the scene.

BUG=none
TEST=none
R=jamesr@chromium.org

Committed: https://crrev.com/6531de858f7c917d471fdb8c65fd2c4dc3715491
Cr-Commit-Position: refs/heads/master@{#291901}

[jamesr, 2014-08-26 04:51:25]

lgtm

https://codereview.chromium.org/507563002/diff/20001/mojo/services/view_manag...
File mojo/services/view_manager/node.cc (right):

https://codereview.chromium.org/507563002/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/node.cc:32: DCHECK(child && child != this &&
!child->Contains(this));
nit: if one of these checks fail it'll be pretty hard to figure out which one.
if you expand this out to three DCHECKs then if any fail it'll point right to
the line that failed

https://codereview.chromium.org/507563002/diff/20001/mojo/services/view_manag...
File mojo/services/view_manager/root_view_manager.h (right):

https://codereview.chromium.org/507563002/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/root_view_manager.h:71: // Owned by it's parent
aura::Window.
nittiest of the nits: "its"

[sky, 2014-08-26 13:10:54]

https://codereview.chromium.org/507563002/diff/20001/mojo/services/view_manag...
File mojo/services/view_manager/node.cc (right):

https://codereview.chromium.org/507563002/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/node.cc:32: DCHECK(child && child != this &&
!child->Contains(this));
On 2014/08/26 04:51:25, jamesr wrote:
> nit: if one of these checks fail it'll be pretty hard to figure out which one.
> if you expand this out to three DCHECKs then if any fail it'll point right to
> the line that failed

Done (here and similar).

https://codereview.chromium.org/507563002/diff/20001/mojo/services/view_manag...
File mojo/services/view_manager/root_view_manager.h (right):

https://codereview.chromium.org/507563002/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/root_view_manager.h:71: // Owned by it's parent
aura::Window.
On 2014/08/26 04:51:25, jamesr wrote:
> nittiest of the nits: "its"

Done.

[sky, 2014-08-26 13:11:07]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-08-26 13:12:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/507563002/40001

[commit-bot: I haz the power, 2014-08-26 14:07:50]

Committed patchset #3 (40001) as a2a6a43f227786bb6691f4ac48f05c4bf7aac65b

[commit-bot: I haz the power, 2014-09-10 02:42:45]

Patchset 3 (id:??) landed as
https://crrev.com/6531de858f7c917d471fdb8c65fd2c4dc3715491
Cr-Commit-Position: refs/heads/master@{#291901}