LayoutTests/fast/forms/setrangetext-within-events.html - Issue 507533002: Fix to keep the selection of the text field in input element after setSelectionRange is called by d…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/setrangetext-within-events.html

Issue 507533002: Fix to keep the selection of the text field in input element after setSelectionRange is called by d… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix the indentation of HTML document Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	yosin_UTC9 2014/08/26 03:55:07 nit: We don't need to have HTML and HEAD. nit: We don't need to have HTML and HEAD. yosin_UTC9 2014/08/26 03:55:08 nit: Please <!DOCTYPE html>. We prefer to use stri nit: Please <!DOCTYPE html>. We prefer to use strict mode.
	2 <head>

	3 <script>

	4 function test() {

	5 if (window.testRunner && window.eventSender) {

	6 testRunner.dumpAsText();

	7 doSetSelectionRange("focus");

	8 doSetSelectionRange("mousedown");

	9 doSetSelectionRange("mouseup");

	10 doSetSelectionRange("click");

	11 }

	12 }

	13 function doSetSelectionRange (event) {
	yosin_UTC9 2014/08/26 03:55:07 nit: Please insert a blank line to separate functi nit: Please insert a blank line to separate function definitions. yosin_UTC9 2014/08/26 03:55:08 nit: No need to have a space between function name nit: No need to have a space between function name and parameter list.
	14 var textfield = document.getElementById('textfield');
	yosin_UTC9 2014/08/26 03:55:07 nit: Please use one type of quote in script, L7-L8 nit: Please use one type of quote in script, L7-L8 use double quote. We prefer single quote.
	15 var tx = textfield.offsetLeft + textfield.offsetWidth / 2;

	16 var ty = textfield.offsetTop + 4;

	17 textfield.addEventListener(event, setSelectionRange);

	18 eventSender.mouseMoveTo(tx, ty);

	19 eventSender.mouseDown();

	20 eventSender.mouseUp();

	21 alert('start: ' + textfield.selectionStart + ' end: ' + textfield.select ionEnd + ' [' + event + ']');
	yosin_UTC9 2014/08/26 03:55:08 Could you use "resources/js-test.js" framework? Could you use "resources/js-test.js" framework?
	22

	23 eventSender.mouseMoveTo(tx, ty+100);
	yosin_UTC9 2014/08/26 03:55:07 nit: Please have spaces around \|+\|. nit: Please have spaces around \|+\|.
	24 eventSender.mouseDown();

	25 eventSender.mouseUp();

	26 textfield.removeEventListener(event, setSelectionRange, false);
	yosin_UTC9 2014/08/26 03:55:08 nit: You don't need to have third argument \|false\| nit: You don't need to have third argument \|false\|. Default is \|false\|.
	27 }

	28 function setSelectionRange(e) {
	yosin_UTC9 2014/08/26 03:55:08 We can omit parameter \|e\|. Since, it isn't used. We can omit parameter \|e\|. Since, it isn't used.
	29 var textfield = document.getElementById('textfield');

	30 textfield.setSelectionRange(0, textfield.value.length)

	31 }

	32 </script>

	33 </head>

	34 <body onload="test()">
	yosin_UTC9 2014/08/26 03:55:07 nit: You can use window.onload = function() { ... nit: You can use window.onload = function() { ... };
	35 <input type="text" value="value" id="textfield"></input>

	36 </body>

	37 </html>

	38
	yosin_UTC9 2014/08/26 03:55:07 nit: Please remove an extra blank line. nit: Please remove an extra blank line.
OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/setrangetext-within-events-expected.txt » ('j') | Source/core/editing/FrameSelection.h » ('J')