Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 507513002: Add some more context to git-drover tutorial. (Closed)

Created:
6 years, 4 months ago by Michael Moss
Modified:
6 years, 4 months ago
Reviewers:
iannucci1, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Add some more context to git-drover tutorial. BUG=407284 R=iannucci@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291619

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -23 lines) Patch
M man/html/depot_tools.html View 3 chunks +26 lines, -1 line 0 comments Download
M man/html/git-drover.html View 1 3 chunks +22 lines, -8 lines 0 comments Download
M man/man1/git-drover.1 View 1 3 chunks +23 lines, -9 lines 0 comments Download
M man/man7/depot_tools.7 View 3 chunks +19 lines, -4 lines 0 comments Download
M man/src/git-drover.demo.1.sh View 1 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Moss
6 years, 4 months ago (2014-08-25 23:34:46 UTC) #1
iannucci
iannucci@chromium.org changed reviewers: + iannucci@chromium.org
6 years, 4 months ago (2014-08-25 23:38:37 UTC) #2
iannucci
lgtm https://codereview.chromium.org/507513002/diff/1/man/html/git-drover.html File man/html/git-drover.html (right): https://codereview.chromium.org/507513002/diff/1/man/html/git-drover.html#newcode791 man/html/git-drover.html:791: # IMPORTANT!!! Do Not leave off the '-x' ...
6 years, 4 months ago (2014-08-25 23:38:37 UTC) #3
Michael Moss
https://codereview.chromium.org/507513002/diff/1/man/src/git-drover.demo.1.sh File man/src/git-drover.demo.1.sh (right): https://codereview.chromium.org/507513002/diff/1/man/src/git-drover.demo.1.sh#newcode39 man/src/git-drover.demo.1.sh:39: pcommand git cl upload On 2014/08/25 23:38:37, iannucci wrote: ...
6 years, 4 months ago (2014-08-25 23:47:33 UTC) #4
Michael Moss
The CQ bit was checked by mmoss@chromium.org
6 years, 4 months ago (2014-08-25 23:56:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/507513002/20001
6 years, 4 months ago (2014-08-25 23:56:25 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 23:58:18 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 291619

Powered by Google App Engine
This is Rietveld 408576698