device/common/BUILD.gn - Issue 507503002: Remove BrowserThread dependency from usb_service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/common/BUILD.gn

Issue 507503002: Remove BrowserThread dependency from usb_service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do the same to chrome/browser/BUILD.gn. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("common") {	5 source_set("common") {
	Ken Rockot(use gerrit already) 2014/08/28 21:47:03 I don't like "common" very much because it carries I don't like "common" very much because it carries the connotation that it's OK to be a dependency of basically any code, browser or renderer. In the context of chrome this is strictly for browser process usage. I would recommend //device/core which won't carry the same connotation. I also don't feel TOO strongly about this, so feel free to argue around it if you like. Reilly Grant (use Gerrit) 2014/08/28 22:16:13 Done. Show quoted text On 2014/08/28 21:47:03, Ken Rockot wrote: > I don't like "common" very much because it carries the connotation that it's OK > to be a dependency of basically any code, browser or renderer. In the context of > chrome this is strictly for browser process usage. > > I would recommend //device/core which won't carry the same connotation. > > I also don't feel TOO strongly about this, so feel free to argue around it if > you like. Done.
6 sources = [	6 sources = [

7 "content_settings_types.h",	7 "device_client.cc",

	8 "device_client.h",

8 ]	9 ]

9 }	10 }

OLD	NEW