Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 50743005: Moved extension_api to src/extensions/common (Closed)

Created:
7 years, 1 month ago by benwells
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Moved extension_api to src/extensions/common This is part of the move of extensions code into the extensions component. This change does not move the generated API data and API resources. TBR=darin@chromium.org BUG=162530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232345

Patch Set 1 #

Patch Set 2 : Android / ios #

Patch Set 3 : Oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -631 lines) Patch
M chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/event_router.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 4 chunks +0 lines, -8 lines 0 comments Download
D chrome/common/extensions/api/extension_api.h View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/common/extensions/api/extension_api.cc View 1 chunk +0 lines, -416 lines 0 comments Download
D chrome/common/extensions/api/extension_api_stub.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/render_view_observer_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/v8_schema_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/DEPS View 1 chunk +13 lines, -1 line 0 comments Download
A + extensions/common/extension_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/extension_api_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
benwells
The depencency on grit and the generated APIs is still there.
7 years, 1 month ago (2013-10-31 06:11:26 UTC) #1
Yoyo Zhou
grit: I asked jam@ about this and he said it's ok until we decide we ...
7 years, 1 month ago (2013-10-31 20:24:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/50743005/110001
7 years, 1 month ago (2013-10-31 20:32:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=33767
7 years, 1 month ago (2013-10-31 21:09:26 UTC) #4
benwells
+tbr darin as presubmit thinks I added third_party/re2 to extensions/common/DEPS (I just put a comma ...
7 years, 1 month ago (2013-10-31 23:16:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/50743005/110001
7 years, 1 month ago (2013-11-01 00:18:01 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217181
7 years, 1 month ago (2013-11-01 05:32:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/50743005/110001
7 years, 1 month ago (2013-11-01 06:05:49 UTC) #8
darin (slow to review)
On 2013/10/31 23:16:59, benwells wrote: > +tbr darin as presubmit thinks I added third_party/re2 to ...
7 years, 1 month ago (2013-11-01 06:52:04 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 13:07:40 UTC) #10
Message was sent while issue was closed. 
Change committed as 232345

Powered by Google App Engine
This is Rietveld 408576698