Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: content/public/browser/web_contents_view_delegate.h

Issue 507363002: MacViews: Guard Objective-C bits in content::WebContentsViewDelegate with __OBJC__ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix content_browsertests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_view_delegate.h
diff --git a/content/public/browser/web_contents_view_delegate.h b/content/public/browser/web_contents_view_delegate.h
index b0e3f6255b90fd9be86762263706cd7b71a78a56..c2d8d543b7de0b6b82268fc692ea1b0bea09cce4 100644
--- a/content/public/browser/web_contents_view_delegate.h
+++ b/content/public/browser/web_contents_view_delegate.h
@@ -2,31 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_WIN_DELEGATE_H_
-#define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_WIN_DELEGATE_H_
-
-#if defined(OS_MACOSX)
-#import <Cocoa/Cocoa.h>
-#endif
+#ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_DELEGATE_H_
+#define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_DELEGATE_H_
#include "content/common/content_export.h"
-#include "ui/gfx/native_widget_types.h"
-
-#if defined(OS_MACOSX)
-@protocol RenderWidgetHostViewMacDelegate;
-#endif
namespace gfx {
class Size;
}
-namespace ui {
-class FocusStoreGtk;
-}
-
namespace content {
class RenderFrameHost;
-class RenderWidgetHost;
+class WebContentsViewDelegateMac;
class WebDragDestDelegate;
struct ContextMenuParams;
@@ -34,33 +21,29 @@ struct ContextMenuParams;
// WebContentsView implementation.
class CONTENT_EXPORT WebContentsViewDelegate {
public:
- virtual ~WebContentsViewDelegate() {}
+ virtual ~WebContentsViewDelegate();
// Returns a delegate to process drags not handled by content.
- virtual WebDragDestDelegate* GetDragDestDelegate() = 0;
+ virtual WebDragDestDelegate* GetDragDestDelegate();
// Shows a context menu.
virtual void ShowContextMenu(RenderFrameHost* render_frame_host,
- const ContextMenuParams& params) = 0;
-
-#if defined(USE_AURA)
- // These methods allow the embedder to intercept WebContentsViewWin's
- // implementation of these WebContentsView methods. See the WebContentsView
- // interface documentation for more information about these methods.
- virtual void StoreFocus() = 0;
- virtual void RestoreFocus() = 0;
- virtual bool Focus() = 0;
- virtual void TakeFocus(bool reverse) = 0;
- virtual void SizeChanged(const gfx::Size& size) = 0;
-#elif defined(OS_MACOSX)
- // Returns a newly-created delegate for the RenderWidgetHostViewMac, to handle
- // events on the responder chain.
- virtual NSObject<RenderWidgetHostViewMacDelegate>*
- CreateRenderWidgetHostViewDelegate(
- RenderWidgetHost* render_widget_host) = 0;
-#endif
+ const ContextMenuParams& params);
+
+ // These methods allow the embedder to intercept a WebContentsView's
+ // implementation of these methods. See the WebContentsView interface
+ // documentation for more information about these methods.
+ virtual void StoreFocus();
+ virtual void RestoreFocus();
+ virtual bool Focus();
+ virtual void TakeFocus(bool reverse);
+ virtual void SizeChanged(const gfx::Size& size);
+
+ // On Mac, returns a subclass that has additional Objective-C methods defined.
+ // Otherwise NULL.
+ virtual WebContentsViewDelegateMac* AsWebContentsViewDelegateMac();
};
} // namespace content
-#endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_WIN_DELEGATE_H_
+#endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698