Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 507333003: Roll DEPS on GTM to remove references to deprecated iOS methods. (Closed)

Created:
6 years, 3 months ago by lliabraa
Modified:
6 years, 3 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll DEPS on GTM to remove references to deprecated iOS methods. sizeWithFont: and drawInRect:withFont:lineBreakMode:alignment: were deprecated in iOS 7. This CL roll GTM to a revision where those methods are no longer used (when building against iOS 7 or later). BUG=405578 Committed: https://crrev.com/c8fa96234de83ca4b15ebdae7c76975103576475 Cr-Commit-Position: refs/heads/master@{#292259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
lliabraa
lliabraa@chromium.org changed reviewers: + stuartmorgan@chromium.org
6 years, 3 months ago (2014-08-27 17:25:32 UTC) #1
lliabraa
6 years, 3 months ago (2014-08-27 17:25:33 UTC) #2
stuartmorgan
lgtm
6 years, 3 months ago (2014-08-27 18:58:18 UTC) #3
lliabraa
The CQ bit was checked by lliabraa@chromium.org
6 years, 3 months ago (2014-08-27 22:03:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/507333003/1
6 years, 3 months ago (2014-08-27 22:05:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d69fd314cd63a77888dfbc136475fa9b6f22d105
6 years, 3 months ago (2014-08-27 23:04:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8fa96234de83ca4b15ebdae7c76975103576475
Cr-Commit-Position: refs/heads/master@{#292259}

Powered by Google App Engine
This is Rietveld 408576698