Enrich fileBrowserPrivate.onFileTransfersUpdated event to support displaying total number of jobs.

chrome/browser/chromeos/extensions/file_manager/event_router.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_EVENT_ROUTER_H_
 #define CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_EVENT_ROUTER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 163 matching lines @@
       extensions::api::file_browser_private::MountCompletedEventType event_type,
       chromeos::MountError error,
       const VolumeInfo& volume_info);
 
   // If needed, opens a file manager window for the removable device mounted at
   // |mount_path|. Disk.mount_path() is empty, since it is being filled out
   // after calling notifying observers by DiskMountManager.
   void ShowRemovableDeviceInFileManager(VolumeType type,
                                         const base::FilePath& mount_path);
 
-  // Sends onFileTranferUpdated to extensions if needed. If |always| is true,
-  // it sends the event always. Otherwise, it sends the event if enough time has
-  // passed from the previous event so as not to make extension busy.
-  void SendDriveFileTransferEvent(bool always);
-
   // Manages the list of currently active Drive file transfer jobs.
   struct DriveJobInfoWithStatus {
     DriveJobInfoWithStatus();
     DriveJobInfoWithStatus(const drive::JobInfo& info,
                            const std::string& status);
     drive::JobInfo job_info;
     std::string status;
   };
+
+  // Schedule onFileTransferUpdated event.
+  void ScheduleDriveFileTransferEvent(const drive::JobInfo& job_info,
+                                      const std::string& status,
+                                      bool immediate);
+
+  // Sends onFileTranferUpdated to extensions if after nextSendTime_.
+  void SendDriveFileTransferEvent();
+
   std::map<drive::JobID, DriveJobInfoWithStatus> drive_jobs_;
+  scoped_ptr<DriveJobInfoWithStatus> drive_job_info_with_status_;
   base::Time last_file_transfer_event_;
   base::Time last_copy_progress_event_;
+  base::Time next_send_file_transfer_event_;
+
+  const base::TimeDelta delay_time_;

[hirono, 2014/09/01 09:41:46]

1. Does it need to be a member of class? We usually tries to reduce the number
of members because header files are shared widely.
2. Please make the name more descriptive. The delay_time is actually only for
file transfer events. It's OK the name is a bit long because the variable is
used only once.

[iseki, 2014/09/01 11:30:54]

Done.

+  const base::TimeDelta force_send_interval_;

[hirono, 2014/09/01 09:41:46]

ditto

[iseki, 2014/09/01 11:30:54]

Done.

 
   WatcherMap file_watchers_;
   scoped_ptr<PrefChangeRegistrar> pref_change_registrar_;
   Profile* profile_;
 
   content::NotificationRegistrar notification_registrar_;
   bool multi_user_window_manager_observer_registered_;
 
   scoped_ptr<DeviceEventRouter> device_event_router_;
 
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate the weak pointers before any other members are destroyed.
   base::WeakPtrFactory<EventRouter> weak_factory_;
   DISALLOW_COPY_AND_ASSIGN(EventRouter);
 };
 
 }  // namespace file_manager
 
 #endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_EVENT_ROUTER_H_