Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 507203003: Remove prettyprinters for JSC::Identifier and JSC::JSString. (Closed)

Created:
6 years, 3 months ago by mstensho (USE GERRIT)
Modified:
6 years, 3 months ago
Reviewers:
tony
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove prettyprinters for JSC::Identifier and JSC::JSString. These classes are not part of Blink (or Chromium, for that matter). R=tony@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M Tools/gdb/webkit.py View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mstensho (USE GERRIT)
6 years, 3 months ago (2014-08-27 10:37:46 UTC) #1
tony
LGTM
6 years, 3 months ago (2014-08-27 14:29:08 UTC) #2
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 3 months ago (2014-08-27 14:30:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/507203003/1
6 years, 3 months ago (2014-08-27 14:30:53 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-08-27 15:36:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 180982

Powered by Google App Engine
This is Rietveld 408576698