Turns on filtering compile everywhere

scripts/slave/recipes/chromium_trybot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 DEPS = [
   'bot_update',
   'chromium',
   'chromium_tests',
@@ skipping 499 matching lines @@
 
 
 def should_filter_tests(name, regexs):
   """Returns true if the builder |name| should filter the sets of tests.
   |regexs| is a list of the regular expressions specifying the builders that
   should *not* be filtered. If |name| completely matches one of the regular
   expressions than false is returned, otherwise true."""
   return not does_regex_match(name, regexs)
 
 
+def should_filter_compile(name, regexs):
+  """Returns true if the builder |name| should filter the sets of compile
+  targets. |regexs| is a list of the regular expressions specifying the
+  builders that should *not* be filtered. If |name| completely matches one of
+  the regular expressions than false is returned, otherwise true."""
+  return not does_regex_match(name, regexs)
+
+
 def get_test_names(gtest_tests, swarming_tests):
   """Returns the names of each of the tests in |gtest_tests| and
   |swarming_tests|. These are lists of GTestTest and SwarmingGTestTest."""
   return [test.name for test in gtest_tests + swarming_tests]
 
 
 def filter_tests(possible_tests, needed_tests):
   """Returns a list of all the tests in |possible_tests| whose name is in
   |needed_tests|."""
   result = []
@@ skipping 232 matching lines @@
                all_compile_targets(conditional_tests),
           compile_targets=compile_targets,
           env=runhooks_env)
       if not api.filter.result:
         return [], swarming_tests, bot_update_step
       # Patch needs compile. Filter the list of test and compile targets.
       if should_filter_tests(buildername,
                              test_spec.get('non_filter_tests_builders', [])):
         gtest_tests = filter_tests(gtest_tests, api.filter.matching_exes)
         swarming_tests = filter_tests(swarming_tests, api.filter.matching_exes)
-      if buildername in test_spec.get('filter_compile_builders', []):
+      if should_filter_compile(buildername,
+                               test_spec.get('non_filter_compile_builders',
+                                             [])):
         if 'all' in compile_targets:
           compile_targets = api.filter.compile_targets
         else:
           compile_targets = list(set(compile_targets) &
                                  set(api.filter.compile_targets))
         # Always add |matching_exes|. They will be covered by |compile_targets|,
         # but adding |matching_exes| makes determing if conditional tests are
         # necessary easier. For example, if we didn't do this we could end up
         # with chrome_run as a compile_target and not chrome (since chrome_run
         # depends upon chrome). This results in not picking up
@@ skipping 445 matching lines @@
     )
   )
 
   # Tests analyze module by way of not specifying non_filter_builders and
   # analyze result returning true. This should result in a compile.
   yield (
     api.test('compile_because_of_analyze') +
     props(buildername='linux_chromium_rel') +
     api.platform.name('linux') +
     api.override_step_data('read test spec', api.json.output({
+        'non_filter_compile_builders': ['linux_chromium_rel'],
       })
     ) +
     api.override_step_data(
       'analyze',
       api.json.output({'status': 'Found dependency', 'targets': [],
                        'build_targets': []}))
   )
 
   # Tests analyze module by way of specifying non_filter_builders and
   # analyze result returning true along with a smaller set of tests.
   yield (
     api.test('compile_because_of_analyze_with_filtered_tests_no_builder') +
     props(buildername='linux_chromium_rel') +
     api.platform.name('linux') +
     api.override_step_data('read test spec', api.json.output({
         'non_filter_tests_builders': ['linux_chromium_rel'],
+        'non_filter_compile_builders': ['linux_chromium_rel'],
         'gtest_tests': [
           {
             'test': 'base_unittests',
             'swarming': {'can_use_on_swarming_builders': True},
           },
           {
             'test': 'browser_tests',
           },
           {
             'test': 'unittests',
           },
         ],
       })
     ) +
     api.override_step_data(
       'analyze',
       api.json.output({'status': 'Found dependency',
                        'targets': ['browser_tests', 'base_unittests'],
                        'build_targets': ['browser_tests', 'base_unittests']}))
   )
 
   # Tests analyze module by way of not specifying non_filter_builders and
   # analyze result returning true along with a smaller set of tests. This
   # specifices a 'filter_test_builder', so that this bot uses the filtered set.
   yield (
     api.test('compile_because_of_analyze_with_filtered_tests') +
     props(buildername='linux_chromium_rel') +
     api.platform.name('linux') +
     api.override_step_data('read test spec', api.json.output({
+        'non_filter_compile_builders': ['linux_chromium_rel'],
         'gtest_tests': [
           {
             'test': 'base_unittests',
             'swarming': {'can_use_on_swarming_builders': True},
           },
           {
             'test': 'browser_tests',
           },
           {
             'test': 'unittests',
           },
         ],
       })
     ) +
     api.override_step_data(
       'analyze',
       api.json.output({'status': 'Found dependency',
                        'targets': ['browser_tests', 'base_unittests'],
                        'build_targets': ['browser_tests', 'base_unittests']}))
   )
 
   # Tests compile_target portion of analyze module.
   yield (
     api.test('compile_because_of_analyze_with_filtered_compile_targets') +
     props(buildername='linux_chromium_rel') +
     api.platform.name('linux') +
     api.override_step_data('read test spec', api.json.output({
-        'filter_compile_builders': 'linux_chromium_rel',
         'gtest_tests': [
           {
             'test': 'base_unittests',
             'swarming': {'can_use_on_swarming_builders': True},
           },
           {
             'test': 'browser_tests',
           },
           {
             'test': 'unittests',
@@ skipping 20 matching lines @@
         'compile_targets': ['base_unittests'],
         'gtest_tests': [
           {
             'test': 'browser_tests',
             'args': '--gtest-filter: *NaCl*',
           }, {
             'test': 'base_tests',
             'args': ['--gtest-filter: *NaCl*'],
           },
         ],
-        'filter_compile_builders': 'linux_chromium_browser_asan_rel',
       })
     ) +
     api.override_step_data(
       'analyze',
       api.json.output({'status': 'Found dependency',
                        'targets': ['browser_tests', 'base_unittests'],
                        'build_targets': ['base_unittests']}))
   )