ui/file_manager/video_player/js/video_player.js - Issue 507173004: Video Player: Add null-check on playback error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/video_player/js/video_player.js

Issue 507173004: Video Player: Add null-check on playback error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/video_player/js/video_player.js

diff --git a/ui/file_manager/video_player/js/video_player.js b/ui/file_manager/video_player/js/video_player.js

index 47940eaef3e6bc058f606ba865b5613f834951ef..dc69257645bc0653403a51548d6c99595cb84d3f 100644

--- a/ui/file_manager/video_player/js/video_player.js

+++ b/ui/file_manager/video_player/js/video_player.js

@@ -105,7 +105,7 @@ FullWindowVideoControls.prototype.showErrorMessage = function(message) {

* @private

FullWindowVideoControls.prototype.onPlaybackError_ = function(error) {

- if (error.target &&

+ if (error.target && error.target.error &&

error.target.error.code === MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED) {

this.showErrorMessage('GALLERY_VIDEO_ERROR');

this.decodeErrorOccured = false;

« no previous file with comments | « no previous file | no next file » | no next file with comments »