mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc - Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/serial/serial_api.cc ('K') | « mojo/services/public/cpp/surfaces/tests/surface_unittest.cc ('k') | mojo/services/window_manager/window_manager_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

index ec4ec6125e49e64a32221d8882b6c50eecc8f67a..88b3548b021637c4b421c3e50180f54c2b07e6ab 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

@@ -301,7 +301,7 @@ void ViewManagerClientImpl::OnEmbed(

if (!connected_) {

connected_ = true;

connection_id_ = connection_id;

- creator_url_ = TypeConverter<String, std::string>::ConvertFrom(creator_url);

+ creator_url_ = String::From(creator_url);

} else {

DCHECK_EQ(connection_id_, connection_id);

DCHECK_EQ(creator_url_, creator_url);