mojo/services/html_viewer/blink_url_request_type_converters.cc - Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/html_viewer/blink_url_request_type_converters.cc

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/serial/serial_api.cc ('K') | « mojo/services/html_viewer/blink_url_request_type_converters.h ('k') | mojo/services/html_viewer/html_document_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/html_viewer/blink_url_request_type_converters.cc

diff --git a/mojo/services/html_viewer/blink_url_request_type_converters.cc b/mojo/services/html_viewer/blink_url_request_type_converters.cc

index 1f6553eba83a2cecf11cc013c0900dfd9c5e15b2..9428d921a5b3bd325a007f85db63499a0ef443d2 100644

--- a/mojo/services/html_viewer/blink_url_request_type_converters.cc

+++ b/mojo/services/html_viewer/blink_url_request_type_converters.cc

@@ -91,7 +91,7 @@ void AddRequestBody(URLRequest* url_request,

} // namespace

-URLRequestPtr TypeConverter<URLRequestPtr, blink::WebURLRequest>::ConvertFrom(

+URLRequestPtr TypeConverter<URLRequestPtr, blink::WebURLRequest>::Convert(

const blink::WebURLRequest& request) {

URLRequestPtr url_request(URLRequest::New());

url_request->url = request.url().string().utf8();