extensions/browser/api/serial/serial_connection.h - Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_connection.h

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/serial/serial_api.cc ('K') | « extensions/browser/api/serial/serial_api.cc ('k') | extensions/browser/api/serial/serial_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/serial/serial_connection.h

diff --git a/extensions/browser/api/serial/serial_connection.h b/extensions/browser/api/serial/serial_connection.h

index 638b89859cd5814155ba4f11201de6d85048b9c1..8af1bf52f7c21266c5b4713864ef5852a7f5ac7f 100644

--- a/extensions/browser/api/serial/serial_connection.h

+++ b/extensions/browser/api/serial/serial_connection.h

@@ -196,18 +196,16 @@ class SerialConnection : public ApiResource,

namespace mojo {

template <>

-class TypeConverter<device::serial::HostControlSignalsPtr,

- extensions::core_api::serial::HostControlSignals> {

- public:

- static device::serial::HostControlSignalsPtr ConvertFrom(

+struct TypeConverter<device::serial::HostControlSignalsPtr,

+ extensions::core_api::serial::HostControlSignals> {

+ static device::serial::HostControlSignalsPtr Convert(

const extensions::core_api::serial::HostControlSignals& input);

};

template <>

-class TypeConverter<device::serial::ConnectionOptionsPtr,

- extensions::core_api::serial::ConnectionOptions> {

- public:

- static device::serial::ConnectionOptionsPtr ConvertFrom(

+struct TypeConverter<device::serial::ConnectionOptionsPtr,

+ extensions::core_api::serial::ConnectionOptions> {

+ static device::serial::ConnectionOptionsPtr Convert(

const extensions::core_api::serial::ConnectionOptions& input);

};