extensions/browser/api/serial/serial_api.h - Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_api.h

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc ('k') | extensions/browser/api/serial/serial_api.cc » ('j') | extensions/browser/api/serial/serial_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/serial/serial_api.h

diff --git a/extensions/browser/api/serial/serial_api.h b/extensions/browser/api/serial/serial_api.h

index 272f11724a7636c61ef07f4ea00e2a29b6c8d3d5..1f6b1065caac75587502bfc0004a04c4311d0c39 100644

--- a/extensions/browser/api/serial/serial_api.h

+++ b/extensions/browser/api/serial/serial_api.h

@@ -246,10 +246,9 @@ class SerialSetControlSignalsFunction : public SerialAsyncApiFunction {

namespace mojo {

template <>

-class TypeConverter<device::serial::DeviceInfoPtr,

- linked_ptr<extensions::core_api::serial::DeviceInfo> > {

- public:

- static linked_ptr<extensions::core_api::serial::DeviceInfo> ConvertTo(

+struct TypeConverter<linked_ptr<extensions::core_api::serial::DeviceInfo>,

+ device::serial::DeviceInfoPtr> {

+ static linked_ptr<extensions::core_api::serial::DeviceInfo> Convert(

const device::serial::DeviceInfoPtr& input);

};