mojo/public/cpp/bindings/struct_ptr.h - Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/struct_ptr.h

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile for real Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/struct_ptr.h

diff --git a/mojo/public/cpp/bindings/struct_ptr.h b/mojo/public/cpp/bindings/struct_ptr.h

index ad77d60b08423ab87b20283a66a7363dbdf7e36d..12ec13533c51c96478b88fd91cfe97e8f834dca3 100644

--- a/mojo/public/cpp/bindings/struct_ptr.h

+++ b/mojo/public/cpp/bindings/struct_ptr.h

@@ -41,7 +41,7 @@ class StructPtr {

template <typename U>

U To() const {

- return TypeConverter<StructPtr, U>::ConvertTo(*this);

+ return TypeConverter<U, StructPtr>::Convert(*this);

}

void reset() {

@@ -106,7 +106,7 @@ class InlinedStructPtr {

template <typename U>

U To() const {

- return TypeConverter<InlinedStructPtr, U>::ConvertTo(*this);

+ return TypeConverter<U, InlinedStructPtr>::Convert(*this);

}

void reset() {

« no previous file with comments | « mojo/public/cpp/bindings/string.h ('k') | mojo/public/cpp/bindings/tests/sample_service_unittest.cc » ('j') | no next file with comments »