Issue 50713004: GM is passing the wrong flag to beginRecording() for --rtree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 50713004: GM is passing the wrong flag to beginRecording() for --rtree. (Closed)

Created:
7 years, 1 month ago by mtklein

Modified:
7 years, 1 month ago

Reviewers:
epoger, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

GM is passing the wrong flag to beginRecording() for --rtree. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12011

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gm/gmmain.cpp	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

epoger

lgtm https://codereview.chromium.org/50713004/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/50713004/diff/1/gm/gmmain.cpp#newcode1727 gm/gmmain.cpp:1727: gm, kRTree_BbhType, SkPicture::kOptimizeForClippedPlayback_RecordingFlag); LGTM I don't know anything ...

7 years, 1 month ago (2013-10-29 20:36:43 UTC) #2

mtklein

+reed Thanks Elliot. Shopping for a reviewer who does know.

7 years, 1 month ago (2013-10-29 20:39:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/50713004/1

7 years, 1 month ago (2013-10-29 20:51:45 UTC) #5

Message was sent while issue was closed.

Change committed as 12011

Expand Messages | Collapse Messages