Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Side by Side Diff: device/serial/serial_service_unittest.cc

Issue 507053002: Remove implicit conversions from scoped_refptr to T* in device/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Regenerate Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/serial_io_handler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "device/serial/serial.mojom.h" 8 #include "device/serial/serial.mojom.h"
9 #include "device/serial/serial_service_impl.h" 9 #include "device/serial/serial_service_impl.h"
10 #include "device/serial/test_serial_io_handler.h" 10 #include "device/serial/test_serial_io_handler.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 } 63 }
64 64
65 void OnGotInfo(serial::ConnectionInfoPtr options) { 65 void OnGotInfo(serial::ConnectionInfoPtr options) {
66 connected_ = true; 66 connected_ = true;
67 StopMessageLoop(); 67 StopMessageLoop();
68 } 68 }
69 69
70 scoped_refptr<SerialIoHandler> ReturnIoHandler() { return io_handler_; } 70 scoped_refptr<SerialIoHandler> ReturnIoHandler() { return io_handler_; }
71 71
72 void RunConnectTest(const std::string& path, bool expecting_success) { 72 void RunConnectTest(const std::string& path, bool expecting_success) {
73 if (!io_handler_) 73 if (!io_handler_.get())
74 io_handler_ = new TestSerialIoHandler; 74 io_handler_ = new TestSerialIoHandler;
75 mojo::InterfacePtr<serial::SerialService> service; 75 mojo::InterfacePtr<serial::SerialService> service;
76 mojo::BindToProxy( 76 mojo::BindToProxy(
77 new SerialServiceImpl( 77 new SerialServiceImpl(
78 new SerialConnectionFactory( 78 new SerialConnectionFactory(
79 base::Bind(&SerialServiceTest::ReturnIoHandler, 79 base::Bind(&SerialServiceTest::ReturnIoHandler,
80 base::Unretained(this)), 80 base::Unretained(this)),
81 base::MessageLoopProxy::current()), 81 base::MessageLoopProxy::current()),
82 scoped_ptr<SerialDeviceEnumerator>(new FakeSerialDeviceEnumerator)), 82 scoped_ptr<SerialDeviceEnumerator>(new FakeSerialDeviceEnumerator)),
83 &service); 83 &service);
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 TEST_F(SerialServiceTest, ConnectInvalidPath) { 132 TEST_F(SerialServiceTest, ConnectInvalidPath) {
133 RunConnectTest("invalid_path", false); 133 RunConnectTest("invalid_path", false);
134 } 134 }
135 135
136 TEST_F(SerialServiceTest, ConnectOpenFailed) { 136 TEST_F(SerialServiceTest, ConnectOpenFailed) {
137 io_handler_ = new FailToOpenIoHandler; 137 io_handler_ = new FailToOpenIoHandler;
138 RunConnectTest("device", false); 138 RunConnectTest("device", false);
139 } 139 }
140 140
141 } // namespace device 141 } // namespace device
OLDNEW
« no previous file with comments | « device/serial/serial_io_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698