Issue 507053: Differentiate between ADD and CHANGED when adding new autofill entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 507053: Differentiate between ADD and CHANGED when adding new autofill entries. (Closed)

Created:
11 years ago by skrul

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, not_the_right_glider, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, jam, dank, Aaron Boodman, stuartmorgan, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), native-client-reviews_googlegroups.com, amit, Timur Iskhodzhanov, DaveMoore

Visibility:
Public.

Description

Differentiate between ADD and CHANGED when adding new autofill entries. Adding a new autofill entry can either result in an ADD (when the name/value par was never seen before) or with an UPDATE (when the name/value pair already exists). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35108

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -65 lines)			Patch
M	chrome/browser/webdata/web_data_service.cc	View	2 chunks	+8 lines, -11 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service_unittest.cc	View	9 chunks	+69 lines, -30 lines	0 comments	Download
M	chrome/browser/webdata/web_database.h	View	2 chunks	+14 lines, -6 lines	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View	3 chunks	+21 lines, -7 lines	0 comments	Download
M	chrome/browser/webdata/web_database_unittest.cc	View	6 chunks	+60 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages